Skip to content

fix(timeline): render events that are still encrypted and refresh on decryption - #1555

Merged
eleboucher merged 2 commits into
devfrom
fix/encrypted-rows
Aug 1, 2026
Merged

fix(timeline): render events that are still encrypted and refresh on decryption#1555
eleboucher merged 2 commits into
devfrom
fix/encrypted-rows

Conversation

@eleboucher

@eleboucher eleboucher commented Aug 1, 2026

Copy link
Copy Markdown
Member

Description

messages in encrypted rooms didn't appear until you scrolled or refocused.

getType() returns m.room.encrypted until decryption finishes, but the render filter listed 'm.room.message.encrypted', which isn't a real type. b1ac4a6 turned that filter into a hard drop, so undecrypted events got no row, and nothing re-ran the filter once they decrypted.

also fixes messages that fail to decrypt showing nothing instead of the placeholder.

based on refactor/matrix-event-type-constants, which kept the bogus string as ROOM_MESSAGE_DECRYPTED. nothing sets that type, so it's removed.

Fixes #1553
Fixes #1508

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Base automatically changed from refactor/matrix-event-type-constants to dev August 1, 2026 14:26
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1555-sable.raspy-dream-bb1d.workers.dev 606daa5 pr-1555 Sat, 01 Aug 2026 14:44:12 GMT

@eleboucher
eleboucher added this pull request to the merge queue Aug 1, 2026
Merged via the queue into dev with commit 1f81361 Aug 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some rooms unresponsive until you scroll through them Timeline doesn't follow new messages when at bottom

2 participants