Skip to content

fix(sliding-sync): keep an accepted invite joined when the server replays stale invite state - #1537

Merged
7w1 merged 1 commit into
fix/sliding-sync-stale-display-namesfrom
fix/sliding-sync-stale-invite-after-join
Jul 31, 2026
Merged

fix(sliding-sync): keep an accepted invite joined when the server replays stale invite state#1537
7w1 merged 1 commit into
fix/sliding-sync-stale-display-namesfrom
fix/sliding-sync-stale-invite-after-join

Conversation

@eleboucher

Copy link
Copy Markdown
Member

Description

repair the m.room.member event alongside selfMembership so a replayed invite cannot revert an accepted join, and clear the invite the sidebar cache persisted

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher changed the base branch from dev to fix/sliding-sync-stale-display-names July 31, 2026 15:22
@eleboucher
eleboucher force-pushed the fix/sliding-sync-stale-invite-after-join branch from 6bf73ed to a418641 Compare July 31, 2026 16:03
@7w1
7w1 force-pushed the fix/sliding-sync-stale-invite-after-join branch from a418641 to 8e81a29 Compare July 31, 2026 20:06
@7w1
7w1 force-pushed the fix/sliding-sync-stale-invite-after-join branch from 8e81a29 to 3836bfe Compare July 31, 2026 20:27
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1537-sable.raspy-dream-bb1d.workers.dev 3836bfe pr-1537 Fri, 31 Jul 2026 20:30:12 GMT

@7w1
7w1 added this pull request to the merge queue Jul 31, 2026
Merged via the queue into dev with commit 99200b0 Jul 31, 2026
13 checks passed
@eleboucher
eleboucher deleted the fix/sliding-sync-stale-invite-after-join branch July 31, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants