fix(notifications): fail open encrypted unified push - #1452
Merged
Conversation
7w1
approved these changes
Jul 28, 2026
7w1
enabled auto-merge
July 28, 2026 22:40
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1452-sable.raspy-dream-bb1d.workers.dev | 8dd2049 | pr-1452 |
Tue, 28 Jul 2026 22:41:56 GMT |
hazre
reviewed
Jul 28, 2026
Comment on lines
+671
to
+684
| const key = `${userId}\u0000${roomId}`; | ||
| let enrichmentCache: RoomNotifCache | undefined; | ||
| let enrichmentMessage: NotifMessage | undefined; | ||
| const posted = await enqueueRoomOperation(key, async () => { | ||
| const cache = getOrCreateRoomCache(userId, roomId, roomName); | ||
| if (eventId && (cache.pendingEventIds.has(eventId) || cache.seenEventIds.has(eventId))) { | ||
| return false; | ||
| } | ||
| if (eventId) cache.pendingEventIds.add(eventId); | ||
| const previousMessages = cache.messages.slice(); | ||
| cache.messages.push(message); | ||
| if (cache.messages.length > MAX_MESSAGES) { | ||
| cache.messages = cache.messages.slice(-MAX_MESSAGES); | ||
| } |
Member
There was a problem hiding this comment.
seems like handleRichPushPayload and handleMinimalPushPayload are mostly the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix issue with unreliable notifications for desktop and android
Fixes #1448
Type of change
Checklist:
AI disclosure: