Use swiftsimio to read catalogues - #311
Merged
Merged
Conversation
Collaborator
Author
|
@MatthieuSchaller @EvgeniiChaikin do you have any thoughts on this? |
Member
|
Yes, removing the intermediate package is good. I think this is a lot cleaner. We should check with @JBorrow too. This whole set of tools and webpage construction is his original design for EAGLE-XL. |
Collaborator
Author
|
I checked with Josh in SWIFTSIM/pipeline#33, and discussed with Evgenii in person, so merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipeline currently relies on the
velociraptorpython package to read the SOAP catalogues. This PR removes this dependency, and instead switches to using swiftsimio to read the catalogues. This has the advantage of removing the need for maintaining the large translator file, which significantly simplifies the registration script.A run of the pipeline using the current master branch is at https://home.strw.leidenuniv.nl/~mcgibbon/COLIBRE/update_pipeline/old_L25m7_z2/. A run using with these changes (using the same input SOAP catalogue) is at https://github.com/SWIFTSIM/velociraptor-python/blob/master/velociraptor/catalogue/translator.py The majority of plots are identical, but there are some with minor differences. These are due to slightly different binning, since velociraptor casts everything to doubles, but most properties in the soap catalogues are floats. I have verified that casting everything to doubles gives consistent results.
This relies on SWIFTSIM/pipeline#33. If we decide to keep the autoplotter functionality within VR, then this will need updated.
I have removed the
colibre-zoomandeagle-xlconfig files since I don't think they will be used again. I have added a note to the README that they used to exist.