Skip to content

Use swiftsimio to read catalogues - #311

Merged
robjmcgibbon merged 7 commits into
masterfrom
remove_vr
Jun 3, 2026
Merged

Use swiftsimio to read catalogues#311
robjmcgibbon merged 7 commits into
masterfrom
remove_vr

Conversation

@robjmcgibbon

Copy link
Copy Markdown
Collaborator

The pipeline currently relies on the velociraptor python package to read the SOAP catalogues. This PR removes this dependency, and instead switches to using swiftsimio to read the catalogues. This has the advantage of removing the need for maintaining the large translator file, which significantly simplifies the registration script.

A run of the pipeline using the current master branch is at https://home.strw.leidenuniv.nl/~mcgibbon/COLIBRE/update_pipeline/old_L25m7_z2/. A run using with these changes (using the same input SOAP catalogue) is at https://github.com/SWIFTSIM/velociraptor-python/blob/master/velociraptor/catalogue/translator.py The majority of plots are identical, but there are some with minor differences. These are due to slightly different binning, since velociraptor casts everything to doubles, but most properties in the soap catalogues are floats. I have verified that casting everything to doubles gives consistent results.

This relies on SWIFTSIM/pipeline#33. If we decide to keep the autoplotter functionality within VR, then this will need updated.

I have removed the colibre-zoom and eagle-xl config files since I don't think they will be used again. I have added a note to the README that they used to exist.

@robjmcgibbon

Copy link
Copy Markdown
Collaborator Author

@MatthieuSchaller @EvgeniiChaikin do you have any thoughts on this?

@MatthieuSchaller

Copy link
Copy Markdown
Member

Yes, removing the intermediate package is good. I think this is a lot cleaner.

We should check with @JBorrow too. This whole set of tools and webpage construction is his original design for EAGLE-XL.

@robjmcgibbon

Copy link
Copy Markdown
Collaborator Author

I checked with Josh in SWIFTSIM/pipeline#33, and discussed with Evgenii in person, so merging now.

@robjmcgibbon
robjmcgibbon merged commit 9602441 into master Jun 3, 2026
1 check passed
@robjmcgibbon
robjmcgibbon deleted the remove_vr branch June 3, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants