WIP Update the SNIa rate plots in the pipeline

[Fonotec]

This is an update that is mainly related to SNIa. Below I summarize the changes:

1. Update the observational data repository (depends on SWIFTSIM/velociraptor-pipeline-data#115) this MR depends on @MatthieuSchaller
2. Include where possible the corresponding data in the plots
3. Plot the logger file for the cosmic SNIa and CC SN rate
4. Plot the logger file for the cosmic r-processes rates (NS mergers, collapsars, CEJSN) interesting for @correac
5. Calculate the cosmic SNIa and CC rate directly from the amount of stellar mass formed
6. I also added a plot with the cosmic ratio of SNIa and CC SN.
7. Divide the section of SNIa in more sections to keep a good overview. I now have sections for cosmic rates calculated from the stellar mass formed, cosmic rates from loggers, SNIa rates versus gas metallicity, SNIa rates versus SFR or sSFR, SNIa rates versus stellar mass.
8. I reordered some plots such that the first plots that appear are the plots that we want to see first.
9. I added a description of the SNIa model to the model description at the top of the webpage.

[MatthieuSchaller]

Can you also update the submodule version?

[EvgeniiChaikin]

Thanks @Fonotec!

Just to update you on the status: I have started looking into this PR but it will likely take me a couple of more days to finish the review.

[MatthieuSchaller]

Any updates on this? Note that there are merge conflicts.

[EvgeniiChaikin]

Hi @Fonotec !

This branch already looks very good and I really like the variety of new plots and data that it provides!!

I left some small comments below in order to make the scripts more clear.

• My first major comment is about the structure of the scripts. By comparing your 12 news scripts with one another, I identified 6 pairs of scripts where the differences in the code between the two scripts in the pair are small. Here are these pairs

1. diff cosmic_SNIa_rate.py cosmic_log_SNIa_rate.py

132a133
> ax.set_yscale("log")
152c153
< ax.set_ylim(0.0, 1.6)
---
> ax.set_ylim(3e-2, 2.0)
162,167c163
< fig.savefig(f"{output_path}/SNIa_rate_history.png")
< 
< ax.set_xlim(1.02, 0.33)
< ax2.set_xlim(1.02, 0.33)
< 
< fig.savefig(f"{output_path}/SNIa_rate_history_zoom.png")
---
> fig.savefig(f"{output_path}/log_SNIa_rate_history.png")

2. diff cosmic_CC_SN_rate.py cosmic_log_CC_SN_rate.py

131a132
> ax.set_yscale("log")
151c152
< ax.set_ylim(0.0, 26.0)
---
> ax.set_ylim(1e-1, 3e1)
161c162
< fig.savefig(f"{output_path}/CC_SN_rate_history.png")
---
> fig.savefig(f"{output_path}/log_CC_SN_rate_history.png")

3. diff cosmic_log_NSM_rate.py cosmic_log_collapsar_rate.py

63c63
<     
---
> 
77c77
<         ax.plot(scale_factor, NSM_rate.value * multiplicative_factor, zorder=10000)[0]
---
>         ax.plot(scale_factor, collapsar_rate.value * multiplicative_factor, zorder=10000)[0]
128c128
< ax.set_ylim(1e-5, 1e-1)
---
> ax.set_ylim(1e-5, 2.0)
134c134
<     f"NS-NS merger rate [$10^{{-{log_multiplicative_factor}}}$ yr$^{{-1}}$ cMpc$^{{-3}}$]"
---
>     f"Collapsar rate [$10^{{-{log_multiplicative_factor}}}$ yr$^{{-1}}$ cMpc$^{{-3}}$]"
138c138
< fig.savefig(f"{output_path}/log_NSM_rate_history.png")
---
> fig.savefig(f"{output_path}/log_collapsar_rate_history.png")

4. diff cosmic_log_NSM_rate.py cosmic_log_CEJSN_rate.py

63c63
<     
---
> 
77c77
<         ax.plot(scale_factor, NSM_rate.value * multiplicative_factor, zorder=10000)[0]
---
>         ax.plot(scale_factor, CEJSN_rate.value * multiplicative_factor, zorder=10000)[0]
134c134
<     f"NS-NS merger rate [$10^{{-{log_multiplicative_factor}}}$ yr$^{{-1}}$ cMpc$^{{-3}}$]"
---
>     f"Common-envelop jets SN rate [$10^{{-{log_multiplicative_factor}}}$ yr$^{{-1}}$ cMpc$^{{-3}}$]"
138c138
< fig.savefig(f"{output_path}/log_NSM_rate_history.png")
---
> fig.savefig(f"{output_path}/log_CEJSN_rate_history.png")

and also
5. diff cosmic_log_SNIa_rate_CSFH_based.py cosmic_SNIa_rate_CSFH_based.py
6. diff cosmic_log_CC_SN_rate_CSFH_based.py cosmic_CC_SN_rate_CSFH_based.py

The pipeline supports an option to use a single script for creating multiple plots (see e.g. https://github.com/SWIFTSIM/pipeline-configs/blob/master/colibre/config.yml#L275). This is done by passing extra parameters to the script to let it know which plot to create. I recommend that you make use of this feature. Then instead of 12 scripts, there will be only 6 scripts, which will thus reduce the amount of code by ~50 per cent (and, hence, the chance of a bug in the code). This will also make the pipeline faster because there will be less repeating calculations and less readings from a file.

• Second, please adjust the y limits in the CC SN rate plots. My tests of this branch show that sometimes the data can be outside the plots' domains

• Finally, I have got the impression that the cosmic CC SN rate is higher when computed from the SNII file compared to when computed from the SFH file. Here are the plots of the two rates:

Do you know what is the reason for this difference?

[EvgeniiChaikin]

Wouldn't it be clearer to just give units of $\rm M_\odot^{-1}$ after the value of this parameter in the right column of the table, instead of saying per Msun in the name of this parameter?

The same comment also applies to the other lines of the code below whose text contains SNIa efficiency.

[Fonotec]

Yes, you are right, I will change this

[EvgeniiChaikin]

You have plots that show different things (e.g. log vs. linear SNIa rate). But you use the same caption and title for both plots, as if it was the same plot. Please be more specific and reflect in the caption and in the title what is different between the plots. E.g. if the plot is in long, then I would write log both in the caption and in the title.

The same comment applies also to the cosmic CC SN rate. And also SNIa / CC SN both CSFH based and not CSFH based.

[EvgeniiChaikin]

All other cases are exponential?

What if no DTD model is used?

[MatthieuSchaller]

This needs merging master into when ready.

[EvgeniiChaikin]

Is this ready for the second review, @Fonotec, or are you planning to make more changes?

[Fonotec]

I am making some more edits, I will let you know when I am done.

[MatthieuSchaller]

@EvgeniiChaikin are you happy with the new version?