Set hostless depth and store SnapshotOfLastSatellite - #152
Open
robjmcgibbon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depthcould be nonzero for hostless subhaloes sinceFillDepth()only recurses through FOF groups. They are now explicitly reset toDepth = 0each snapshot.Add a new field,
SnapshotOfLastSatellite, the most recent snapshot a subhalo was a satellite, similar to the existingSnapshotOfLastIsolation. When identifying backsplash galaxies this lets you jump straight to the relevant snapshot to identify the former host, instead of walking back through every earlier output.