Add experimental routing image patch for feature_flag_latent_bug_hotel_reservation benchmark - #6
Merged
Saadmrp1038 merged 2 commits intoJul 20, 2026
Conversation
…l_reservation benchmark Two minimal changes to support the custom frontend image used by the feature_flag_latent_bug_hotel_reservation SREGym problem (PR #791): - services/frontend/server.go: flag-gated error handler — when SEARCH_BACKEND_VERSION=true, searchHandler returns HTTP 500 on every hotel search request while all pods remain Running - Dockerfile: pin zerolog to v1.28.0 for Go 1.17 compatibility (newer zerolog versions use log/slog, added in Go 1.21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR supports the custom frontend image used by the
feature_flag_latent_bug_hotel_reservationbenchmark problem inSREGym PR #791.
Changes
Two minimal changes to
hotelReservation:services/frontend/server.go— adds a flag-gated error handler atthe top of
searchHandler. WhenSEARCH_BACKEND_VERSION=true, everyhotel search request returns HTTP 500 with a generic error message while
all pods remain Running. When the flag is unset or
false, the handlerbehaves identically to the original.
Dockerfile— pinszerologtov1.28.0. Newer versions ofzerologuselog/slogwhich was added in Go 1.21. The existingDockerfile uses
golang:1.17.3, so without this pin the build failswith
cannot find package log/slog.Image
The custom image built from this patch is currently at
sharqm/hotelreservation:experimental-routing-v3. Once a sharedregistry is confirmed, it will be moved there.