Issue-3938 rest_deploy should throw errors just like SOAP deploy does#3940
Merged
jstvz merged 3 commits intoMay 27, 2026
Merged
Conversation
Add import of MetadataApiError and MetadataComponentFailure to rest_deploy.py (was missing, causing NameError). Update tests to expect the new exceptions via pytest.raises.
jstvz
force-pushed
the
bug/issue-3938-rest-deploy-error
branch
from
f275acf to
06697fa
Compare
jstvz
approved these changes
May 27, 2026
Contributor
jstvz
left a comment
jstvz
left a comment
There was a problem hiding this comment.
Required checks pass (3.11-3.13). Branch updated to current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If cumulusCI Deploy task is using REST to do the metadata deploy, errors happen silently and the task reports success. This is different from when using SOAP, which will raise an exception.
Add exception raising to the Rest_deploy handler.