Skip to content

chore: add commit format enforcement and chore vs fix guidance in maintenance skill #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussellSB merged 2 commits into from
Jul 23, 2026
Merged

chore: add commit format enforcement and chore vs fix guidance in maintenance skill #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93d16c0
chore: add commit format enforcement and chore/fix/CI guidance to mai…
opencode-agent[bot] Jul 23, 2026
30a6de8
ci: add pull-requests:read permission and GH_TOKEN to base branch check
opencode-agent[bot] Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/check-base-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,12 @@ jobs:
check-base-branch:
name: Validate Base Branch
runs-on: ubuntu-latest
permissions:
pull-requests: read
steps:
- name: Ensure PR targets allowed base branch
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
BASE="${{ github.base_ref }}"
HEAD="${{ github.head_ref }}"
Expand Down
5 changes: 4 additions & 1 deletion .opencode/skills/maintenance/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ description: Use when making ANY code change to pytrendy, creating issues, or op

# Maintenance & API evolution

This is the consolidated context issue #141 asked for — the design principles agents keep re-litigating on PRs.
> **CRITICAL: Before EVERY `git commit`, verify the message matches `^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\(.+\))?!?: .+`. If not, rewrite it. No exceptions.**
>
> **CRITICAL: Before EVERY PR title creation, verify the title matches the same pattern. `lint-pr-title.yml` enforces this in CI — PRs with non-conforming titles are blocked.**

## Public API surface

Expand Down Expand Up @@ -84,6 +86,7 @@ Segment dicts have at minimum: `direction` ('Up'/'Down'/'Flat'/'Noise'), `start`
- `lint-pr-title.yml` rejects titles not matching `^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\(.+\))?!?: .+`.
- semantic-release maps: `feat`→minor, `fix`→patch, `!`/`BREAKING CHANGE:`→major, others→no bump.
- Deprecating a public API param = `feat:` (minor), *not* `refactor:` — see "Deprecation policy" section above.
- **`chore` vs `fix`**: `fix:` triggers a **patch release** via semantic-release. Use `chore:` or `ci:` for maintenance-only changes that have zero user-facing code impact. Using `fix:` on non-bugfix work causes accidental auto-releases.
- Imperative, lowercase, <72 chars, no trailing period.

## Don't touch these manually
Expand Down
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,7 @@ Other skills (`test`, `cicd`, `debug`, `pr-plots`) load on demand for specific t
- Lowercase, imperative, <72 chars, no trailing period
- This applies to all commit messages you generate, including auto-generated summaries
- `lint-pr-title.yml` enforces the `type: description` prefix and allowed types on PR titles (regex: `^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\(.+\))?!?: .+`)
- **PR titles use the same pattern** — non-conforming titles are blocked in CI
- Deprecating a public param = `feat:` (minor), NOT `refactor:`
- **`chore` vs `fix`**: `fix:` triggers a **patch release** via semantic-release. Use `chore:` or `ci:` for maintenance-only changes that have zero user-facing code impact. Using `fix:` on non-bugfix work causes accidental auto-releases.
- Never hand-edit `pyproject.toml` version or `CHANGELOG.md`
Loading