docs(whats-new): add what's new entry for v1.4.0-dev.1 - #232
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📚 Docs preview removed The docs preview for this PR has been cleaned up. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RussellSB
left a comment
There was a problem hiding this comment.
Added comments for improvement
|
/oc address the above review |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
All review comments addressed:
|
RussellSB
left a comment
There was a problem hiding this comment.
/oc address new comments
|
/oc address unresolved comments from new review iteration |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
All review comments addressed:
|
| - **Legend positioning** — move the legend with `legend_loc` and `legend_bbox_to_anchor`. | ||
|
|
||
| For the full list of supported keys, see the [`plot_params` reference](../reference/pytrendy/detect_trends.md#plot_params). | ||
| For the full list of supported keys, see the [`plot_params` reference](https://github.com/RussellSB/pytrendy/blob/develop/pytrendy/io/plot_pytrendy.py). |
There was a problem hiding this comment.
no ref api docs page for method with params
There was a problem hiding this comment.
Also backticks still on plot_params make it [plot_params reference]
| colors={"Up": "mediumseagreen", "Down": "lightsalmon"}, | ||
| grid={"visible": False}, | ||
| legend_loc="lower left", | ||
| legend_loc="upper left", |
There was a problem hiding this comment.
How come this doesnt move to upper left?
|
/oc address each comment seperately, investigate, and reply to comments |
|
/oc try again, i updated your permissions now |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
All four issues addressed in
|
| - **Grid control** — toggle grid visibility and customise its appearance via the `grid` dict. | ||
| - **Legend positioning** — move the legend with `legend_loc` and `legend_bbox_to_anchor`. | ||
|
|
||
| For the full list of supported keys, see the [plot_params reference](reference/pytrendy/detect_trends/#pytrendy.detect_trends.detect_trends). |
There was a problem hiding this comment.
still not working, try: /reference/pytrendy/detect_trends/#pytrendy.detect_trends.detect_trends(plot_params)
RussellSB
left a comment
There was a problem hiding this comment.
/oc address the link comment, and make an issue centred around: grid visible not making a difference, and improving the params for legend positioning, seems to break image can use these as examples:
grid: False (does nothing, should remove grid lines)
# Custom appearance
pt.detect_trends(
df, date_col="date", value_col="gradual",
plot_params=dict(
figsize=(20, 4),
title="Gradual Trend — Custom Visual",
grid={"visible": False}
),
)
legend_loc= upper left (breaks image)
# Custom appearance
pt.detect_trends(
df, date_col="date", value_col="gradual",
plot_params=dict(
figsize=(20, 4),
title="Gradual Trend — Custom Visual",
grid={"visible": False},
legend_loc="upper left"
),
)
legend loc has some weird interaction with legend bbox to anchor:
# Custom appearance
pt.detect_trends(
df, date_col="date", value_col="gradual",
plot_params=dict(
figsize=(20, 4),
title="Gradual Trend — Custom Visual",
grid={"visible": False},
legend_loc="upper left",
legend_bbox_to_anchor=(0.5, 0.5)
),
)
Also side note (include in issue) .... docstring needs fixing for plot_params, renders broken atm:

|
/oc above review submit should have triggered you? Maybe cause its review comment ? diff from request changes? Anyways address what it says, |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
The link is fixed. I can't create the GitHub issue because Here's what was done:
Remaining (needs gh auth):
To create these manually: gh issue create --title "fix(plot_params): grid visibility broken, legend positioning erratic" --body-file /tmp/issue-body.md --label "bug"
gh issue create --title "feat(ci): trigger opencode on PR review comments containing /oc" --body "Review comments with /oc commands don't trigger the opencode agent..." --label "enhancement"Skipped: investigating plot_params bugs (requires running the code), creating issues (no gh auth). |
|
/oc fixes resolved. ALongside demo'd example consider showing grid colour black opacity 0.8, and legend loc upper left or something |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
Done. Updated the
Regenerated both |
|
/oc redo the after example without the bbox to anchor legend spec, let the code handle for that implicitly so output actually moves legend to top left |
|
/oc also update to latest dev ref dev2 instead of dev1. Plot params spans versions dev1-dev2 |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
Done. Removed |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
Updated |
|
/oc make legend loc bottom left instead for after example. Also make span note on the plot param intro more consice, like dev1 introduced, dev2 improved |
Co-authored-by: RussellSB <RussellSB@users.noreply.github.com>
|
Done. Changes:
|








📚 Automated What's New update
This PR was generated automatically by the What's New Generator workflow
after the
v1.4.0-dev.1release was published.What changed
docs/whats-new.mdusing OpenCode(
opencode-go/deepseek-v4-flash) to summarise the release notes in a user-friendly way.Review checklist