refactor: extract index detection and boundary remapping from detect_trends#216
Open
github-actions[bot] wants to merge 2 commits into
Open
refactor: extract index detection and boundary remapping from detect_trends#216github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…trends - Extract _detect_index_type() helper function for index type detection - Fix index_lookup construction to use positional zip (was label-based) - Use dedicated _pytrendy_idx scratch column instead of overwriting date_col - Remove duplicate import warnings and unused imports - Fix docstring typos: timestamps → dates, segmenets → segments
github-actions
Bot
requested review from
ChrisMarsden833
and removed request for
RussellSB
July 9, 2026 06:41
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
📚 Docs preview deployed! Your docs preview is available at: https://russellsb.github.io/pytrendy/pr-216/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the index detection logic in detect_trends.py:
All tests pass after these changes.