fix: allow null premium default to unblock order creation#2434
Open
kanishka0411 wants to merge 1 commit intoRoboSats:mainfrom
Open
fix: allow null premium default to unblock order creation#2434kanishka0411 wants to merge 1 commit intoRoboSats:mainfrom
kanishka0411 wants to merge 1 commit intoRoboSats:mainfrom
Conversation
Contributor
|
I believe it would make sense to restrict this behavior to buy orders. It is less likely that a seller would like to sell for market price, and one could accidentally forget to fill the premium field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2433
This PR introduces/refactors/...
"Create Order" button stays disabled when the premium field is left untouched, because defaultMaker sets premium: null and the validation rejects non-number types. Fixed by allowing null premium in disableSubmit (treating it as 0% market price) and using ?? 0 in price/limit math to prevent NaN.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.