Skip to content

My change#210

Open
luisrosales852 wants to merge 1 commit into
mainfrom
luisChange
Open

My change#210
luisrosales852 wants to merge 1 commit into
mainfrom
luisChange

Conversation

@luisrosales852

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new weekly spotlight entry to the HRI integration team’s running progress log.

Changes:

  • Inserted a new spotlight section for 2026-03-03.
  • Added an updated member status table for that week.
  • Documented a development update related to NLP tests and HRI extraction/confirmation behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@@ -1,5 +1,6 @@
# Weekly Spotlights


Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra blank line after the H1 header. Consider removing it to keep spacing consistent with the rest of the document (single blank line between header and first paragraph).

Suggested change

Copilot uses AI. Check for mistakes.
| Oscar | |

- **Development**
- Made nlp tests pass by adding an LLM fallback for extract data node in HRI and a condition so that when a phrase gets classified as no or yes by a thin margin compared to I dont know it returns I dont know.

Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo/grammar: "I dont know" is missing an apostrophe. Please change it to "I don't know" (both occurrences in this sentence).

Suggested change
- Made nlp tests pass by adding an LLM fallback for extract data node in HRI and a condition so that when a phrase gets classified as no or yes by a thin margin compared to I dont know it returns I dont know.
- Made nlp tests pass by adding an LLM fallback for extract data node in HRI and a condition so that when a phrase gets classified as no or yes by a thin margin compared to I don't know it returns I don't know.

Copilot uses AI. Check for mistakes.
Comment on lines +29 to +32
- Made nlp tests pass by adding an LLM fallback for extract data node in HRI and a condition so that when a phrase gets classified as no or yes by a thin margin compared to I dont know it returns I dont know.



Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The development bullet is a single long run-on sentence and is hard to scan in a weekly spotlight. Consider splitting it into multiple bullets or sentences, and formatting node/component names (e.g., extract data node / ask_and_confirm) as inline code for readability.

Suggested change
- Made nlp tests pass by adding an LLM fallback for extract data node in HRI and a condition so that when a phrase gets classified as no or yes by a thin margin compared to I dont know it returns I dont know.
- Made nlp tests pass by adding an LLM fallback for the `extract data` node in HRI.
- Added a condition so that when a phrase is classified as "no" or "yes" by a thin margin compared to "I dont know", it returns "I dont know".

Copilot uses AI. Check for mistakes.
@Oscar-gg

Copy link
Copy Markdown
Member

What's up with this pr @luisrosales852 @GilMM27 ? Should it be updated & merged, or should we close it?

Also @luisrosales852 use descriptive and appropriate names for both the branch, and pr title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants