Add solution for Challenge 3 by murtaza-kgl by murtaza-kgl · Pull Request #1636 · RezaSi/go-interview-practice

murtaza-kgl · 2026-04-30T04:19:45Z

Challenge 3 Solution

Submitted by: @murtaza-kgl
Challenge: Challenge 3

Description

This PR contains my solution for Challenge 3.

Changes

Added solution file to challenge-3/submissions/murtaza-kgl/solution-template.go

Testing

Solution passes all test cases
Code follows Go best practices

Thank you for reviewing my submission! 🚀

coderabbitai · 2026-04-30T04:19:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84a6d018-aa8c-452e-ab96-33156e072c75

📥 Commits

Reviewing files that changed from the base of the PR and between d062b38 and 9bc6e05.

📒 Files selected for processing (1)

challenge-3/submissions/murtaza-kgl/solution-template.go

🚧 Files skipped from review as they are similar to previous changes (1)

challenge-3/submissions/murtaza-kgl/solution-template.go

Walkthrough

Adds a new Go solution file introducing Employee and Manager types and methods: AddEmployee, RemoveEmployee, GetAverageSalary, and FindEmployeeByID. Includes a main demonstrating adding, removing, averaging, and finding employees.

Changes

Challenge 3 Solution

Layer / File(s)	Summary
Data Shape `challenge-3/submissions/murtaza-kgl/solution-template.go`	Adds `Employee` struct (`ID`, `Name`, `Age`, `Salary`) and `Manager` struct (`Employees []Employee`).
Core Methods `challenge-3/submissions/murtaza-kgl/solution-template.go`	Adds `(Manager).AddEmployee`, `RemoveEmployee` (uses `slices.IndexFunc` and `slices.Delete`), `GetAverageSalary` (returns 0.0 for empty), and `FindEmployeeByID` (returns `Employee` or `nil`).
Wiring / Demo `challenge-3/submissions/murtaza-kgl/solution-template.go`, `go.mod`	Implements `main()` to instantiate a `Manager`, add two employees, remove one by ID, print average salary, and print found employee details. `go.mod` present for module context.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Add solution for Challenge 1 by ismarinated #1110: Adds near-identical Employee/Manager types and the same Manager methods in challenge-3.
Add solution for Challenge 3 by imankhodadi #1016: Implements the same types and Manager methods plus a main entrypoint in the challenge-3 solution.
Add solution for Challenge 3 by varshaguna #1622: Provides a very similar Go implementation of Employee and Manager and the same set of methods.

Poem

🐰 I hopped through slices, swift and spry,
I added friends beneath the sky.
Remove a fox, compute the pay,
Find the mate who stayed to stay.
A tiny rabbit cheers: hooray! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a solution for Challenge 3 by a specific contributor.
Description check	✅ Passed	The description is clearly related to the changeset, explaining the Challenge 3 solution submission and changes made.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

challenge-3/submissions/murtaza-kgl/solution-template.go (2)
3-3: ⚡ Quick win

Use conventional import formatting.

The semicolon-separated import statement is valid but unconventional. Go style prefers newline-separated imports.
♻️ Conventional import format
-import ("fmt"; "slices")
+import (
+	"fmt"
+	"slices"
+)
43-43: 💤 Low value

Add space before division operator.

Minor formatting: the expression totalSalary /float64(l) should have a space before the / operator for consistency with Go conventions.
♻️ Formatting fix
-	return totalSalary /float64(l)
+	return totalSalary / float64(l)

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33e3c208-f29c-4223-a283-774d51c9e5fb

📥 Commits

Reviewing files that changed from the base of the PR and between bf844ae and d062b38.

📒 Files selected for processing (1)

challenge-3/submissions/murtaza-kgl/solution-template.go

github-actions · 2026-04-30T17:14:06Z

⚠️ Auto-merge failed

Could not automatically merge this PR: Resource not accessible by integration