Fix size computation for responseType: 'blob' results.

[pkaminski]

This change is 

[gemini-code-assist]

Summary of Changes

Hello @pkaminski, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the size of responses with responseType: 'blob' was not being correctly computed, potentially leading to incorrect caching behavior. The fix ensures that Blob objects are properly measured by checking their size property, alongside existing length and byteLength checks, and updates the package version.

Highlights

• Corrected Blob Size Calculation: Modified the logic for determining the size of cacheable responses to properly account for Blob objects, which expose a size property instead of length.
• Version Bump: Incremented the package version from 6.0.0 to 6.0.1 in package.json.

Changelog

• hubkit.js
  • Updated the size calculation for cacheable responses to include rawData.size for Blob objects.
• package.json
  • Bumped the version from 6.0.0 to 6.0.1.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue with calculating the size of cached responses when responseType: 'blob' is used. The change correctly uses the .size property of the Blob object. However, a similar issue exists for responseType: 'arraybuffer' which is not addressed. I've added a suggestion to handle ArrayBuffer as well by checking for the .byteLength property.

[gemini-code-assist]

This change correctly handles Blob responses by checking for rawData.size. However, it doesn't account for ArrayBuffer responses, which have a byteLength property for their size. To make the size calculation more robust for different response types, I suggest also checking for byteLength.

Suggested change

	rawData ? rawData.length || rawData.size :
	rawData ? rawData.length || rawData.size || rawData.byteLength :

[pkaminski]

@pkaminski resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @snoack).

[snoack]

@snoack reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @pkaminski).