Skip to content

Add admin signature validation in RsGenExchange #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zapek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add admin signature validation in RsGenExchange #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion src/gxs/rsgenexchange.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,10 +1114,42 @@ int RsGenExchange::validateGrp(RsNxsGrp* grp)
}

if(idValidate)
{
// Validate admin signature
RsTlvSecurityKeySet keys = metaData.keys;
GxsSecurity::createPublicKeysFromPrivateKeys(keys);
std::map<RsGxsId, RsTlvPublicRSAKey>& public_keys = keys.public_keys;
std::map<RsGxsId, RsTlvPublicRSAKey>::iterator keyMit = public_keys.find(RsGxsId(metaData.mGroupId));

if(keyMit == public_keys.end())
{
#ifdef GEN_EXCH_DEBUG
std::cerr << "RsGenExchange::validateGrp() admin key not found! " << std::endl;
#endif
return VALIDATE_FAIL;
}

std::map<SignType, RsTlvKeySignature>& signSet = metaData.signSet.keySignSet;
std::map<SignType, RsTlvKeySignature>::iterator mit = signSet.find(INDEX_AUTHEN_ADMIN);
if(mit == signSet.end())
{
#ifdef GEN_EXCH_DEBUG
std::cerr << "RsGenExchange::validateGrp() admin sign not found! " << std::endl;
std::cerr << "RsGenExchange::validateGrp() grpId: " << metaData.mGroupId << std::endl;
#endif
return VALIDATE_FAIL;
}
RsTlvKeySignature adminSign = mit->second;
if (!GxsSecurity::validateNxsGrp(*grp, adminSign, keyMit->second))
{
return VALIDATE_FAIL;
}
return VALIDATE_SUCCESS;
}
else
{
return VALIDATE_FAIL;

}
}

bool RsGenExchange::checkAuthenFlag(const PrivacyBitPos& pos, const uint8_t& flag) const
Expand Down
Loading