Use regex to match 'run', 'running', 'runs', and 'ran' when they are …#1
Open
sparklerfish wants to merge 1 commit intoRedWedgeX:masterfrom
Open
Use regex to match 'run', 'running', 'runs', and 'ran' when they are …#1sparklerfish wants to merge 1 commit intoRedWedgeX:masterfrom
sparklerfish wants to merge 1 commit intoRedWedgeX:masterfrom
Conversation
…not preceded or followed by an alphabetic character
Author
|
I was testing the regex in this repl if you'd like to play with it to test as well |
Author
|
Also, I just realized that it's probably not really necessary for this to check for uppercase letters too, since we're converting the message to lowercase, but probably better to leave it there for robustness in case that changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…not preceded or followed by an alphabetic character