Improved verbose messages in rolling functions frolladaptivefun and frollfun#7733
Merged
ben-schwen merged 22 commits intoRdatatable:masterfrom May 7, 2026
Merged
Improved verbose messages in rolling functions frolladaptivefun and frollfun#7733ben-schwen merged 22 commits intoRdatatable:masterfrom
ben-schwen merged 22 commits intoRdatatable:masterfrom
Conversation
Updating Project Fork
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7733 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 87 87
Lines 17058 17064 +6
=======================================
+ Hits 16895 16901 +6
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jangorecki
reviewed
Apr 30, 2026
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Approach is good, just some comments to make it cleaner.
jangorecki
reviewed
May 3, 2026
jangorecki
reviewed
May 3, 2026
… (defined in froll.c & extern in data.table.h)
jangorecki
reviewed
May 5, 2026
jangorecki
reviewed
May 5, 2026
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Trailing white spaces seems to be only remaining thing left.
ben-schwen
reviewed
May 5, 2026
The message now includes our group members as suggested by @ben-schwen
ben-schwen
reviewed
May 6, 2026
ben-schwen
reviewed
May 6, 2026
|
|
||
| 6. `yearqtr()` and `yearmon()` now gain an optional format specifier [#7694](https://github.com/Rdatatable/data.table/issues/7694). 'numeric' is the default, which preserves the original behavior, but 'character' formats `yearqtr()` as YYYYQ# (e.g. 2025Q2) and `yearmon()` as YYYYM## (e.g. 2025M02, 2025M10). Thanks to @jan-swissre for the report and @LunaticSage218 for the implementation. | ||
|
|
||
| 7. Verbose outputs from `frolladaptivefun()` and `frollfun()` are now clearer and more user friendly [#7021](https://github.com/Rdatatable/data.table/issues/7021). Thanks to @Omartech312, @aidengseay, @kkarissa, and @heb229 for the implementation, to @ben-schwen for the review, and to @jangorecki for the extensive guidance and review. |
Member
There was a problem hiding this comment.
I forgot in my last comment.
It's probably fitting best under ### NOTES (maybe under ### BUG FIXES), since its not a real new feature.
ben-schwen
approved these changes
May 6, 2026
Member
ben-schwen
left a comment
ben-schwen
left a comment
There was a problem hiding this comment.
Apart from NEWS (which fits imo better within NOTES than NEW FEATURES), LGTM!
TY!
moved text stating new change from the NEW FEATURES section to Notes.
Member
|
LGTM test.data.table("frollBatch.Rraw")? |
Contributor
Author
|
@jangorecki I believe it does, since we did not modify any logic in the froll functions, only the verbosity of the messages. In our testing, we did not get any flags from test.data.table("frollBatch.Rraw") |
jangorecki
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7021.
Previously, the frolladaptivefun and rfollfun algo verbose messages were not super user friendly, displaying messages like:
frolladaptivefun: algo 0 not implemented, fall back to 1The wanted adjustment was for it to instead produce:
frolladaptivefun: algo fast not implemented, fall back to exactThere was also:
frollfun: processing fun 0 algo 0 took...and the desired result was instead:
frollfun: processing fun mean algo fast took...We adjusted for the desired functionality by creating an array of strings called rfunNames, using the rfun enum as an index to select the proper display type for the running function and then displaying fast or exact dependent on the value of value (0 for fast, 1 for exact).
Here is an example of the current output (from running tests) with the changed files in this PR:
frolladaptivefun: processing fun MIN algo exact took 0.000sfrolladaptivefun: algo fast not implemented, fall back to exactWe have additionally adjusted the NEWS.md file and the corresponding tests in inst/tests/froll.Rraw.