S3 fencing to suspend old Primary from writing to S3.#2417
Open
pruthvitd wants to merge 1 commit intoRamenDR:mainfrom
Open
S3 fencing to suspend old Primary from writing to S3.#2417pruthvitd wants to merge 1 commit intoRamenDR:mainfrom
pruthvitd wants to merge 1 commit intoRamenDR:mainfrom
Conversation
Implements failover marker mechanism to coordinate S3 writes between
clusters during DRAction failover operations. Prevents data corruption
from concurrent writes by suspending old primary's S3 writes when
failover marker is detected.
Key changes:
- Add failover marker creation/removal in DRPC
- Add marker check in VRG before S3 writes
- Add marker phase tracking (initiated/recovering/completed)
Tested the failover scenario with both clusters online, and it successfully prevented split‑brain.
Code adjustments were made to satisfy linter requirements.
AI assistance from Microsoft 365 Copilot (with enterprise data protection
in Microsoft 365 Copilot and Microsoft 365 Copilot Chat) was used for suggestions only.
All changes were reviewed, adapted, and tested by the author.
Co-authored-by: M365 Copilot(Enterprise data protection enabled)
Signed-off-by: pruthvitd <prd@redhat.com>
d3f0848 to
cf814b2
Compare
Member
|
LGTM |
raaizik
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements failover marker mechanism to coordinate S3 writes between clusters during DRAction failover operations. Prevents data corruption from concurrent writes by suspending old primary's S3 writes when failover marker is detected.
Key changes:
Tested the failover scenario with both clusters online, and it successfully prevented split‑brain.
Fixes: #250