Add tests for single s3 store configurations#2384
Add tests for single s3 store configurations#2384raaizik wants to merge 1 commit intoRamenDR:mainfrom
Conversation
raaizik
force-pushed
the
ra-add-single-s3-store-tests
branch
6 times, most recently
from
4fee07d to
f156b4e
Compare
raaizik
force-pushed
the
ra-add-single-s3-store-tests
branch
from
f156b4e to
82c9702
Compare
raaizik
force-pushed
the
ra-add-single-s3-store-tests
branch
4 times, most recently
from
1b7ce20 to
cc0a0e4
Compare
Enables single S3 store testing and prevents CI timeouts through resource grouping. - Add Group field to Test struct for selective test execution - Refactor TestDR with extracted helpers to reduce complexity - Use group filtering Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
raaizik
force-pushed
the
ra-add-single-s3-store-tests
branch
from
cc0a0e4 to
ef7fdf0
Compare
raaizik
requested review from
nirs,
parikshithb and
raghavendra-talur
as code owners
| // Group is an optional field to group related tests (e.g., "single-s3-store") | ||
| // Tests without a group are run by default in the main TestDR | ||
| // Tests with a group can be run selectively by dedicated test functions | ||
| Group string `json:"group,omitempty"` |
There was a problem hiding this comment.
The way to group tests is to create another config file with tests you want to run. See config-vm.yaml and config-recipes.yaml in #2207.
If you want to add grouping feature please open an issue and we can discuss it there. This also affects ramenctl, since it need to run the same tests.
| // This test runs tests marked with group "single-s3-store" from the configuration. | ||
| // It can be used with any configuration file that includes tests with the | ||
| // "single-s3-store" group (e.g., test.yaml, test-single-s3-store.yaml). | ||
| func TestSingleS3Store(dt *testing.T) { |
There was a problem hiding this comment.
Why do we need new test for single s3 store? Why we cannot use the existing dr_test?
This seems to duplicate dr_test, running the same flow.
Please explain what is single s3 store feature, and why it cannot be tested by the current tests.
|
|
||
| // TestSingleS3Store tests disaster recovery scenarios with a single S3 store | ||
| // located on the hub cluster. This validates that RamenDR correctly handles | ||
| // centralized S3 storage for both discovered apps and RBD workloads. |
There was a problem hiding this comment.
This requires environment with single s3 store on the hub - we don't have such configuration. If we create one, the standard dr tests should be able to run with this environment, since the tests do not care about the number and location of the s3 stores. We create resources and trigger dr actions.
s3 configuration comes from ramen configmap, which is part of the environment, not part of the tests.
|
Note that single s3 store configuration will fail I we want to add this feature, we need to allow this in ramenctl. Please open an issue in ramenctl or send a PR to change this. Do we have any documentation for single s3 store? Is this documented configuration in ODF? |
|
For reference, existing issues for extending e2e and ramenctl: |
3 participants
Enables single S3 store testing and prevents CI timeouts through resource grouping.