Skip to content

Bug/5947 campaign halo render order fix#5948

Open
Baaaaaz wants to merge 4 commits intoRPTools:developfrom
Baaaaaz:bug/5947-campaign-halo-render-order-fix
Open

Bug/5947 campaign halo render order fix#5948
Baaaaaz wants to merge 4 commits intoRPTools:developfrom
Baaaaaz:bug/5947-campaign-halo-render-order-fix

Conversation

@Baaaaaz
Copy link
Contributor

@Baaaaaz Baaaaaz commented Mar 22, 2026

Identify the Bug or Feature request

fixes #5947

Description of the Change

Small update to previous HaloRenderer refactoring, added in an ArrayList of ArrayLists to be able to render Halos and their respective haloparts in the special order needed, i.e.:

  • Halos are rendered in reverse order (so outerward halos with the FILL option do not cover over innerward halos)
  • Haloparts are rendered in normal order (so haloparts specified Left -> Right in the campaign halo string syntax are rendered First -> Last (or visually Bottom -> Top))

Possible Drawbacks

None anticipated

Documentation Notes

None

Release Notes

  • Fixed an issue with campaign haloparts rendering

This change is Reviewable

@github-actions github-actions bot added the bug label Mar 22, 2026
@Baaaaaz
Copy link
Contributor Author

Baaaaaz commented Mar 22, 2026

Not sure why the macos build is failing here? @cwisniew any clues?

…on, as hoping prior MacOS issue was transient!)
@Baaaaaz
Copy link
Contributor Author

Baaaaaz commented Mar 23, 2026

Well, well, well, the macos-15 build verification worked this time. Ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Campaign halos (due in 1.19) with multiple halo parts no longer render correctly

1 participant