Skip to content

[ROCm] Fix duplicate hipMemMap call in map_block() causing SIGSEGV #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srinivamd wants to merge 1 commit into
base: release/2.12
Choose a base branch
from
+1 −7
Open

[ROCm] Fix duplicate hipMemMap call in map_block() causing SIGSEGV #3265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions torch/csrc/distributed/c10d/symm_mem/CUDASymmetricMemoryUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ IpcChannel::~IpcChannel() {
}

void IpcChannel::send_fd(int dst_pid, int fd) {
// Because file descriptors are process-local kernel objects, and we can’t
// Because file descriptors are process-local kernel objects, and we can't
// pass them via normal socket payloads (like write() or send()). Unix domain
// sockets provide a mechanism to pass actual FDs via sendmsg()/recvmsg().
// Define destination socket address
Expand Down Expand Up @@ -251,12 +251,6 @@ void map_block(
0,
reinterpret_cast<hipMemGenericAllocationHandle_t>(handle),
0ULL));
C10_CUDA_CHECK(hipMemMap(
*ptr,
size,
0,
reinterpret_cast<hipMemGenericAllocationHandle_t>(handle),
0ULL));

hipMemAccessDesc desc;
desc.location.type = hipMemLocationTypeDevice;
Expand Down