Skip to content

[WaveTransform] Fixes schedule-amdgpu-tracker-physreg-crash.ll test#2596

Open
vg0204 wants to merge 1 commit into
amd-feature/wave-transformfrom
amd/dev/gvikash/fix-schedule-amdgpu-tracker-physreg-crash
Open

[WaveTransform] Fixes schedule-amdgpu-tracker-physreg-crash.ll test#2596
vg0204 wants to merge 1 commit into
amd-feature/wave-transformfrom
amd/dev/gvikash/fix-schedule-amdgpu-tracker-physreg-crash

Conversation

@vg0204
Copy link
Copy Markdown

@vg0204 vg0204 commented May 19, 2026

No description provided.

@vg0204 vg0204 requested a review from cdevadas May 19, 2026 10:30
@vg0204 vg0204 self-assigned this May 19, 2026
@z1-cciauto
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown

@cdevadas cdevadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a TODO comment.

; RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=+xnack -amdgpu-use-amdgpu-trackers=1 2>&1 < %s | FileCheck -check-prefixes=ERR-GCNTRACKERS %s
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=+xnack 2>&1 < %s | FileCheck -check-prefixes=GCN %s
; RUN: not llc -amdgpu-late-wave-transform=1 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=+xnack -amdgpu-use-amdgpu-trackers=1 2>&1 < %s | FileCheck -check-prefixes=ERR-GCNTRACKERS %s
; RUN: not llc -amdgpu-late-wave-transform=1 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=+xnack 2>&1 < %s | FileCheck -check-prefixes=GCN %s
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must somehow make the second RUN line pass. Can you add a TODO-WAVETRANSFORM line just after this line to capture this? We should revisit this test and revert this line by the time we upstream the wave transform feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants