[AMDGPU] comgr: Add ElfView::getKernelLdsSize helper#2583
Merged
Conversation
xintin
added
comgr
jmmartinez
reviewed
May 18, 2026
Adds a small ElfView helper that reads group_segment_fixed_size from the kernel descriptor symbol "<KernelName>.kd". Returns std::nullopt when the descriptor symbol is missing. Assisted-by: Cursor Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
hotswap-elf-getkernellsdsize
branch
from
8390027 to
a3b936b
Compare
Signed-off-by: xintin <gaurav.verma@amd.com>
jmmartinez
reviewed
May 19, 2026
jmmartinez
reviewed
May 19, 2026
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
hotswap-elf-getkernellsdsize
branch
from
d7ad58b to
1dbca97
Compare
jmmartinez
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small
ElfViewhelper that readsgroup_segment_fixed_sizefrom the kernel descriptor symbol<KernelName>.kd. Returnsstd::nulloptwhen the descriptor symbol is missing.Split out as a precursor to the
ds_*_addtid_b32trampoline patch (PR #2302). That patch will use the helper to gate a diagnostic for kernels with LDS allocations larger than the A0 16-bit M0 truncation limit.Unit test
ElfView.GetKernelLdsSizeReturnsNulloptWhenKdMissingcovers the missing-descriptor path with a hand-crafted minimal ELF; the positive path will be exercised through lit once a consumer lands.