Fix int32 overflow in rotating buffer size calculation#2298
Open
Z-Y00 wants to merge 1 commit into
Open
Conversation
When rotating buffer sizes exceed ~2GB, the int32_t multiplication of rotatingNum * rotatingSize wraps negative (e.g. 838926336 * 3 = -1778188288), causing "Insufficient rotating buffer size" abort. Use int64_t for rotatingNum and totalRotatingSizeNeeded to handle large grouped GEMM buffer allocations correctly.
Z-Y00
requested review from
Jinp800125,
KKyang,
Serge45,
TonyYHsieh,
aazz44ss,
hcman2,
imcarsonliao,
jichangjichang,
solaslin and
vin-huang
as code owners
Author
|
Shall I submit PR in the mono repo instead? |
Z-Y00
force-pushed
the
rotation-buffer-overflow
branch
2 times, most recently
from
00db9d8 to
6bad126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is Lorri Rao from AIG model team (lorri.rao@amd.com), trying to fix tensile tunning error for grouped gemm.
Technical Details
When rotating buffer sizes exceed ~2GB, the int32_t multiplication of rotatingNum * rotatingSize wraps negative (e.g. 838926336 * 3 = -1778188288), causing "Insufficient rotating buffer size" abort.
Very similar like 4GB overflow error for 32 sized datatype in memory allocation.
Use int64_t for rotatingNum and totalRotatingSizeNeeded to handle large grouped GEMM buffer allocations correctly.
Test Plan
NA
Test Result
NA
Submission Checklist