merge aomp-dev into amd-staging#2244
Open
z1-cciauto wants to merge 10 commits into
Open
Conversation
Remove xteam-red-min-max-float-multi-device test which depends on -fopenmp-target-multi-device flag. This flag is being removed from ROCm/llvm-project (PR #2277) as part of driver convergence effort. Test purpose was to verify multi-device compilation compatibility with Xteam min/max reduction. With multi-device feature removed, this test becomes redundant. Depends on: ROCm/llvm-project#2277
These tests exercise -fopenmp-target-xteam-scan and -fopenmp-target-xteam-no-loop-scan, which are deprecated in ROCm/llvm-project#2704. The flags and their implementation will be removed once the upstream cross-team reduction rewrite lands in amd-staging.
…and do some tidying
…-tests [smoke] Remove xteam-scan tests
Reverting my last change of the miniQMC remote, as suggested by QMCPack maintainer. The original goal to enable both the QMCPack/miniqmc as a stable/legacy version of the mini-app and the current development version were unsuccessfull. It seems I had done something wrong when I originally posted the PR with the change. This changes a few situation in how we handle missing files or not-set environment variables. It also updates the CMake command with now required cmake options.
…-and-remove [Flang][OpenMP][Fortran-map-tests] Add size zero presence check test and do some tidying
It turns out initialized common blocks are generated to slightly different LLVM-IR than a zero initialized common block, former is a tuple, latter is a byte array. So good to have a test verifying this also functions and continues to do so.
[Flang][OpenMP][fortran-map-tests] Add initialized common block test
…ce-test [smoke-dev] Remove multi-device test
z1-cciauto
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.