[MiniQMC] Update remote, improve script#2225
Conversation
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
Reverting my last change of the miniQMC remote, as suggested by QMCPack maintainer. The original goal to enable both the QMCPack/miniqmc as a stable/legacy version of the mini-app and the current development version were unsuccessfull. It seems I had done something wrong when I originally posted the PR with the change. This changes a few situation in how we handle missing files or not-set environment variables. It also updates the CMake command with now required cmake options.
jplehr
force-pushed
the
feat/add-miniqmc-dev-target
branch
from
883cf1b to
ffc662d
Compare
jplehr
changed the title
|
I completely changed what this PR is meant to do. Reverting my last change of the miniQMC remote, as suggested by QMCPack The original goal to enable both the QMCPack/miniqmc as a stable/legacy This changes a few situation in how we handle missing files or not-set |
|
|
||
| echo "OMP_NUM_THREADS=${MQMC_OMP_NUM_THREADS} ${MQMC_BUILD_DIR}/bin/check_spo_batched_reduction -n 10" | ||
| OMP_NUM_THREADS=${MQMC_OMP_NUM_THREADS} "${MQMC_BUILD_DIR}"/bin/check_spo_batched_reduction -n 10 | ||
| # We intentionally continue running even if some binaries are missing. |
There was a problem hiding this comment.
why would some binaries be missing?
There was a problem hiding this comment.
If you reset to a different version of miniQMC that happened to me as something would not build.
| exit 1 | ||
| fi | ||
|
|
||
| export PATH=$AOMP/bin:$PATH |
There was a problem hiding this comment.
Is it necessary to check if $AOMP is set in this script?
There was a problem hiding this comment.
We could. Not sure if needed.
3 participants
This allows to switch between running the old tag we used internally for some time and the most recent work on OMP_offload user branch.
Sources go to different directory on checkout.
CMake invocation is a bit different.
Build directory is overwritten / reused.