build(cmake): remove rocprofiler-systems GCC and sanitizer guards#5196
Draft
dgaliffiAMD wants to merge 2 commits into
Draft
build(cmake): remove rocprofiler-systems GCC and sanitizer guards#5196dgaliffiAMD wants to merge 2 commits into
dgaliffiAMD wants to merge 2 commits into
Conversation
rocprofiler-systems can be built with Clang and alongside sanitizer configurations. Drop the Linux bootstrap check that required GCC when ROCPROFSYS was enabled, and stop skipping the subproject when THEROCK_SANITIZER is set. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TheRock’s CMake configuration to allow building the rocprofiler-systems subproject under a broader set of toolchain configurations, specifically enabling it with Clang and in sanitizer-enabled builds.
Changes:
- Remove the Linux bootstrap hard-failure that required GNU compilers when
THEROCK_ENABLE_ROCPROFSYS=ON. - Stop skipping
rocprofiler-systemsconfiguration/activation whenTHEROCK_SANITIZERis set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| profiler/CMakeLists.txt | Always enables/configures the rocprofiler-systems subproject when THEROCK_ENABLE_ROCPROFSYS is ON, regardless of sanitizer settings. |
| cmake/therock_compiler_config.cmake | Removes the Linux-only fatal error that enforced GCC for rocprofiler-systems builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Set to `amd-hip`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocprofiler-systems can be built with Clang and alongside sanitizer configurations. Drop the Linux bootstrap check that required GCC when ROCPROFSYS was enabled and stop skipping the subproject when THEROCK_SANITIZER is set.
Technical Details
Test Plan
Test Result
Submission Checklist