[elfutils] Bump bundled elfutils 0.192 -> 0.195#5142
Open
FIM43-Redeye wants to merge 2 commits into
Open
Conversation
elfutils 0.192's libcpu/riscv_disasm.c:1259 discards `const` from a bsearch return, tripping amd-llvm clang's -Werror=incompatible-pointer-types-discards-qualifiers (ROCm#5120) and GCC 15's -Werror=discarded-qualifiers. 0.195 fixes this at source: the result is correctly typed `const struct known_csrs *` (now at :1262). Tarball uploaded to the rocm-third-party-deps S3 mirror by @ScottTodd via ROCm#5139; SHA512 verified against the canonical sourceware tarball. Verified on a full integrate-tip build (Ubuntu 26.04 / GCC 15.2.0 / amd-llvm clang): bundled elfutils builds clean; amd-llvm, debug-tools, profiler, and core consumers re-link without recompilation, confirming 0.192 -> 0.195 is libdw/libelf ABI-compatible. Closes ROCm#5120.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TheRock-bundled elfutils sysdep to a newer upstream release (0.195) by bumping the fetched tarball URL and corresponding integrity hash, addressing the clang/GCC const-discard build failure noted in #5120.
Changes:
- Bump bundled elfutils tarball from 0.192 → 0.195.
- Update the S3 mirror URL and SHA512
URL_HASHto match the 0.195 archive. - Update the “Originally mirrored from” comment to reflect the new upstream source URL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the TheRock-bundled elfutils from 0.192 to 0.195 (released 2026-04-15).
Why
elfutils 0.192's
libcpu/riscv_disasm.c:1259discardsconstfrom absearchreturn, tripping amd-llvm clang's-Werror=incompatible-pointer-types-discards-qualifiers(#5120) and GCC 15's-Werror=discarded-qualifiers. 0.195 fixes this at source — the result is correctly typedconst struct known_csrs *(now at:1262).Same root-cause class as the rocprofsys-vendored elfutils 0.188 backport that landed in rocm-systems#5574 (2026-04-30), but applied at the more current bundled-side version where elfutils carries the fix natively rather than as a downstream patch.
What changes
Single-file:
third-party/sysdeps/linux/elfutils/CMakeLists.txtelfutils-0.195.tar.bz2(uploaded by @ScottTodd via Request: mirror elfutils-0.195.tar.bz2 to rocm-third-party-deps S3 #5139)Verification
libdw.so/libelf.sosoname unchangedCloses #5120.