fix(RC1-002): guest profile avatar navigation and related guest UX fixes

[niamao]

Summary

• Closes RC1-002 Unauthenticated profile icon should navigate to related profile page #353 (RC1-002): make follower/following list avatars navigate to /dashboard/profile/{username} for logged-out users (username already linked; avatar was not).
• Stop intermittent guest toast Cannot read properties of undefined (reading '_id') by gating dashboard GET_CHAT_ROOMS / GET_NOTIFICATIONS pollInterval on loggedIn (Apollo continues polling when skip is true).
• Fix landing hero People search console errors from empty/{} avatar values by using shared DisplayAvatar.

Test plan

• Logged out: open /dashboard/explore, click a post author avatar → lands on that user's public profile
• Logged out: open a profile → Followers → click another user's avatar → lands on that profile
• Logged out: stay on /dashboard/explore for ~20s → no _id toast / no getChatRooms errors
• Landing /: search a name with People results → avatars render with no Image src console errors
• Logged in: chat unread badge still updates (poll resumes)

Made with Cursor

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quotevote	Ready	Preview, Comment	Jul 21, 2026 7:59am

[motirebuma]

Hi @niamao nice work: clean, well-scoped PR. Three fixes in 5 files, all related to guest/unauthenticated UX.

1. Avatar navigation (RC1-002) — wrapping the UserFollowDisplay avatar in a <Link> to the profile page is the right fix. The username was already linked; the avatar wasn't. Good test added for it too.

2. Guest polling fix — gating pollInterval on loggedIn in the dashboard layout is a solid catch. Apollo does keep polling even when skip is true, which was firing authenticated requests for guests and causing the Cannot read properties of undefined (reading '_id') toast. Setting pollInterval: loggedIn ? 60000 : 0 (and 8000 : 0 for chat rooms) is the correct fix.

3. Landing page avatar fix — switching from inline Image/User icon to the shared DisplayAvatar component for hero search People results handles empty/malformed avatar values cleanly and removes the User import that's no longer needed.

The duplicate username property removal in ProfileHeaderMessage.test.tsx is a valid fix too — duplicate object keys are a silent JS issue.

Verdict: approved, ready to merge.

Thank you @niamao

@flyblackbox @niamao