Adding the ability to specify icon alt and aria labels - #53
Merged
Conversation
added 4 commits
March 6, 2026 16:51
…. Marking the icons as decorative so screen readers don't read them. We have the button labels for the screen readers to use.
…'s icons. Marking the icons as decorative so screen readers don't read them. We have the button labels for the screen readers to use." This reverts commit b1cc9d8.
…conAltText. Also made the iconAltText and iconAriaLabel properties not have a default value and it an empty string is a valid value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the ability to specify the Channel's icon Alt Text property,
iconAltTextAlso made the
iconAltTextandiconAriaLabelproperties not have a default value and allow for an empty string as a valid value.Note: the first 2 commits are a No-Op from a previous version and should cancel each other out.