Skip to content

fix: label esc as back in agent detail pager footer (#130) - #136

Merged
QuintinShaw merged 2 commits into
QuintinShaw:mainfrom
vansh2408:fix/issue-130-esc-label-pager-footer
Jul 31, 2026
Merged

fix: label esc as back in agent detail pager footer (#130)#136
QuintinShaw merged 2 commits into
QuintinShaw:mainfrom
vansh2408:fix/issue-130-esc-label-pager-footer

Conversation

@vansh2408

Copy link
Copy Markdown
Contributor

What

Fixes the keyboard shortcut hint in the workflow navigator's agent detail pager footer: esc was labeled summary, duplicating the enter hint. It now reads enter summary · esc back.

Fixes #130

Why

With the pager open, the footer showed enter summary · esc summary, making both keys look like they do the same thing and hiding the fact that Esc is the universal "go back one level" key across the navigator. Every other view already labels it esc back; this was the one deviation.

How

  • src/workflow-ui.ts: changed the footerHint pager-open branch label from "esc summary" to "esc back". Key handling is untouched - keyToAction already maps Esc to back, which closes the pager when it is open.
  • tests/workflow-ui-pager.test.ts: added a test that opens the agent detail pager and asserts the footer shows enter summary and esc back, and does not show esc summary, so this regression is now covered.

@QuintinShaw

Copy link
Copy Markdown
Owner

Thanks — exactly right, and the rendering test asserting the footer content (not just the keymap) is a nice touch. Welcome aboard. Merging.

@QuintinShaw
QuintinShaw merged commit 0363b04 into QuintinShaw:main Jul 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Esc key is incorrectly labeled as “summary” in phase details view

2 participants