fix: label esc as back in agent detail pager footer (#130) - #136
Merged
QuintinShaw merged 2 commits intoJul 31, 2026
Merged
Conversation
Owner
|
Thanks — exactly right, and the rendering test asserting the footer content (not just the keymap) is a nice touch. Welcome aboard. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the keyboard shortcut hint in the workflow navigator's agent detail pager footer:
escwas labeled summary, duplicating theenterhint. It now readsenter summary · esc back.Fixes #130
Why
With the pager open, the footer showed
enter summary · esc summary, making both keys look like they do the same thing and hiding the fact that Esc is the universal "go back one level" key across the navigator. Every other view already labels itesc back; this was the one deviation.How
src/workflow-ui.ts: changed thefooterHintpager-open branch label from"esc summary"to"esc back". Key handling is untouched -keyToActionalready maps Esc toback, which closes the pager when it is open.tests/workflow-ui-pager.test.ts: added a test that opens the agent detail pager and asserts the footer showsenter summaryandesc back, and does not showesc summary, so this regression is now covered.