fix: restore agreed token budget wording - #129
Merged
QuintinShaw merged 2 commits intoJul 23, 2026
Merged
Conversation
Owner
|
Thanks — restoring the exact wording the eval validated is the right call; shipping a paraphrase the harness never saw would quietly invalidate the 3/3 result. I pushed a small commit fixing the comment in the budget test (it credited #127 with the verbatim adoption — that's this PR; #127 was the compression) — hope you don't mind. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up correction to #127.
#127 compressed the reviewed
tokenBudgetschema wording to remain under the existing provider-visible byte ceiling. That was the wrong tradeoff: the agreed language was the requirement, so this PR restores it verbatim and deliberately revises the ceiling instead.Evidence
npx tsx --test tests/workflow-tool.test.ts tests/workflow-prompt-budget.test.ts— 35/35npm run buildnpm run docs:checknpm run context:checknpm run guidance:checknpm run release:verify— 0 warningsnpm run delivery-choice -- --model openai-codex/gpt-5.6-sol:high— 3/3 scenarios passed against the exact wording