Persist reconciliation drift snapshots with trend query#1811
Open
220nightmore-spec wants to merge 1 commit into
Open
Persist reconciliation drift snapshots with trend query#1811220nightmore-spec wants to merge 1 commit into
220nightmore-spec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1713.
Summary
v013_reconciliation_snapshotswith durablerun_at,checked_count,drift_count, andseverityfields plus arun_atindexReconciliationWorkerrun, including RPC-error reportsReconciliationWorker.getDriftTrend(limit)with limit clamping and most-recent-first orderingGET /api/v1/admin/monitoring/reconciliation/trend?limit=...Validation
node .\node_modules\jest\bin\jest.js src\tests\reconciliation.test.ts --runInBand --forceExitupcreates the table/index, accepts a snapshot row, anddowndrops the tablegit diff --checkNotes
db.get is not a functionbecause the runner adapter callsdb.get()on a better-sqlite3 database instance. I left that shared runner behavior unchanged to keep this PR scoped to the reconciliation history feature.tsc --noEmit --pretty falseis currently blocked by an existing syntax error insrc/index.ts; the focused Jest coverage above passes.