Add in planar and factorization tests for ROCTensorMap#462
Open
kshyatt wants to merge 5 commits into
Open
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
kshyatt
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Jun 29, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Looks good to me! You seem to still have some comments about missing/breaking @planar things that I couldn't really understand, is this something to do in this PR?
Otherwise LGTM!
Member
Author
|
Removed the comments and re-enabled some commented out tests. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.