Skip to content

Keep windows-2022 runners for now#1009

Open
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) wants to merge 1 commit into
mainfrom
windows2022
Open

Keep windows-2022 runners for now#1009
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) wants to merge 1 commit into
mainfrom
windows2022

Conversation

@MarcAntoineSchmidtQC

Copy link
Copy Markdown
Member

The updated windows-latest runners have made changes to MSVC that are not yet supported by the cxx-compiler package. Let's keep the runners on windows 2022 for now.

Checklist

  • Added a CHANGELOG.rst entry

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins Windows GitHub Actions runners to windows-2022 (instead of windows-latest) to avoid recent windows-latest MSVC changes that are currently incompatible with the cxx-compiler package, keeping CI and packaging workflows stable.

Changes:

  • Updated the conda package build workflow matrix to run Windows builds on windows-2022.
  • Updated the CI test matrix to run Windows tests on windows-2022.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/package.yml Pins the Windows conda-build matrix entries to windows-2022.
.github/workflows/ci.yml Pins the Windows CI matrix entry to windows-2022.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants