Skip to content

ROCm GPU Fix#711

Open
eessmann wants to merge 1 commit intoQuEST-Kit:develfrom
eessmann:rocm_fix
Open

ROCm GPU Fix#711
eessmann wants to merge 1 commit intoQuEST-Kit:develfrom
eessmann:rocm_fix

Conversation

@eessmann
Copy link
Contributor

Inital hack to get us working on ROCm 7.

Not very happy about the casts and explicit calls to addCuQcomp and mulCuQcomp

@otbrown otbrown changed the title ROMc GPU Fix ROCm GPU Fix Feb 23, 2026
@TysonRayJones
Copy link
Member

TysonRayJones commented Feb 26, 2026

Are you sure addCuQcomp is necessary? The ROCm 6.0 changelog mentions only * and / issues, and your diff doesn't change every + operator into a addCuQcomp call (consider this one). So I suspect

amp = addCuQcomp(amp, mulCuQcomp(coeffs[q], inAmps[q][n]));

could instead be just

amp = amp + mulCuQcomp(coeffs[q], inAmps[q][n]);

and addCuQcomp() deleted.

I'm not even sure that's better, but it'd help the investigation by shrinking the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants