Add Figma skill router#11
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the Figma Skill Router, adding SKILL.md and SKILLS.md to define routing rules, capability gates, and a catalogue index of installed Figma skills. It also adds a test suite in tests/figma_skill_router.test.ts to ensure both markdown files remain identical and that all active Figma skills are indexed. Feedback suggests enhancing the test suite with a bidirectional check to ensure that every skill listed in the router actually exists in the workspace, preventing dead references or typos.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| assert.deepEqual( | ||
| activeSkills.filter((skill) => !listedSkills.has(skill)), | ||
| [], | ||
| "every active Figma skill should be reachable from the router", | ||
| ); |
There was a problem hiding this comment.
The current test ensures that all active skills are listed in the router, but it does not verify the reverse: that every skill listed in the router actually exists in the workspace. Adding a bidirectional check prevents dead references or typos in the router's index when skills are renamed or deleted.
assert.deepEqual(
activeSkills.filter((skill) => !listedSkills.has(skill)),
[],
"every active Figma skill should be reachable from the router",
);
assert.deepEqual(
[...listedSkills].filter((skill) => !activeSkills.includes(skill)),
[],
"every skill listed in the router should exist as an active skill",
);There was a problem hiding this comment.
Pull request overview
This PR adds a “Figma Skill Router” skill to the active Figma skills catalogue, intended to select exactly one appropriate installed skill based on the user’s request and available Figma context, and ensures the router’s direct-upload document remains identical to the canonical skill document.
Changes:
- Added
figma-skill-routerskill documentation (SKILL.md) plus an identicalSKILLS.mdfor direct Figma upload. - Added a Node/TypeScript test to enforce (1) SKILL/SKILLS parity and (2) router index coverage of all other active Figma skills.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/figma_skill_router.test.ts | Adds regression coverage for SKILL.md/SKILLS.md parity and ensures the router indexes all other active Figma skill directories. |
| skills/figma-agent/figma-skill-router/SKILL.md | Introduces the canonical router skill instructions, including routing steps, capability gating, and a catalogue index. |
| skills/figma-agent/figma-skill-router/SKILLS.md | Provides a direct-upload document kept identical to SKILL.md (enforced by test). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Adds a Figma-first router skill that selects one appropriate installed skill from the active catalogue.
SKILLS.mddocument for direct Figma uploadValidation
node --experimental-strip-types --test tests/figma_skill_router.test.tsuv run python scripts/sync_figma_documents.py --checkuv run python scripts/validate_skills.pyuv run ruff check .uv run ruff format --check .