Skip to content

Add Figma skill router#11

Merged
Zochory merged 4 commits into
mainfrom
agent/add-figma-skill-router
Jul 12, 2026
Merged

Add Figma skill router#11
Zochory merged 4 commits into
mainfrom
agent/add-figma-skill-router

Conversation

@Zochory

@Zochory Zochory commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

Adds a Figma-first router skill that selects one appropriate installed skill from the active catalogue.

  • includes capability-aware routing for Figma Agent limitations
  • ships an identical SKILLS.md document for direct Figma upload
  • adds a TypeScript regression test for catalogue coverage and upload parity

Validation

  • node --experimental-strip-types --test tests/figma_skill_router.test.ts
  • uv run python scripts/sync_figma_documents.py --check
  • uv run python scripts/validate_skills.py
  • uv run ruff check .
  • uv run ruff format --check .

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the Figma Skill Router, adding SKILL.md and SKILLS.md to define routing rules, capability gates, and a catalogue index of installed Figma skills. It also adds a test suite in tests/figma_skill_router.test.ts to ensure both markdown files remain identical and that all active Figma skills are indexed. Feedback suggests enhancing the test suite with a bidirectional check to ensure that every skill listed in the router actually exists in the workspace, preventing dead references or typos.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +37 to +41
assert.deepEqual(
activeSkills.filter((skill) => !listedSkills.has(skill)),
[],
"every active Figma skill should be reachable from the router",
);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current test ensures that all active skills are listed in the router, but it does not verify the reverse: that every skill listed in the router actually exists in the workspace. Adding a bidirectional check prevents dead references or typos in the router's index when skills are renamed or deleted.

  assert.deepEqual(
    activeSkills.filter((skill) => !listedSkills.has(skill)),
    [],
    "every active Figma skill should be reachable from the router",
  );
  assert.deepEqual(
    [...listedSkills].filter((skill) => !activeSkills.includes(skill)),
    [],
    "every skill listed in the router should exist as an active skill",
  );

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a “Figma Skill Router” skill to the active Figma skills catalogue, intended to select exactly one appropriate installed skill based on the user’s request and available Figma context, and ensures the router’s direct-upload document remains identical to the canonical skill document.

Changes:

  • Added figma-skill-router skill documentation (SKILL.md) plus an identical SKILLS.md for direct Figma upload.
  • Added a Node/TypeScript test to enforce (1) SKILL/SKILLS parity and (2) router index coverage of all other active Figma skills.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/figma_skill_router.test.ts Adds regression coverage for SKILL.md/SKILLS.md parity and ensures the router indexes all other active Figma skill directories.
skills/figma-agent/figma-skill-router/SKILL.md Introduces the canonical router skill instructions, including routing steps, capability gating, and a catalogue index.
skills/figma-agent/figma-skill-router/SKILLS.md Provides a direct-upload document kept identical to SKILL.md (enforced by test).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Zochory Zochory marked this pull request as ready for review July 12, 2026 17:29
@Zochory Zochory merged commit e027f72 into main Jul 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants