Keycloak Authentication#178
Merged
Merged
Conversation
configures fastAPI to trust traefik headers, fixing a mismatch in the URI scheme between keycloak and fastAPI
…unner into feat-keycloak-auth
…unner into feat-keycloak-auth
rushirajnenuji
approved these changes
Jun 24, 2026
rushirajnenuji
left a comment
rushirajnenuji
left a comment
Member
There was a problem hiding this comment.
Thanks Jeanette, this looks great. I was able to successfully test this set up - both locally and in dev. Passes all unit and integration tests locally (tested with the Traefik PR)
On dev-k8s, I was able to successfully login to Keycloak and get access and refresh tokens. Setting up and using the tokens worked seamlessly as well while submitting the workflows to the service.
Couple of minor suggestions, which could go into this or as a follow on PR. Okay to go ahead and merge this to main
Thank you again @jeanetteclark for your time and efforts to get this support in, and related work to dataone-auth. 🙌🏻🚀
rushirajnenuji
approved these changes
Jun 29, 2026
rushirajnenuji
left a comment
rushirajnenuji
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks @jeanetteclark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #142
This also makes some QOL improvements that make testing easier by removing global variables from the CLI and replacing them with Click contexts instead.
Some minor housekeeping will need to happen before the release:
dataone.authdependency to point to a version when that is released