fix: refactor retrieve_egon_data rule to use curl for data retrieval and ensure output directory exists#46
Merged
lkstrp merged 3 commits intoPyPSA:mainfrom Apr 4, 2025
yechenyan:fix/retrieve_egon_data_error
Merged
fix: refactor retrieve_egon_data rule to use curl for data retrieval and ensure output directory exists#46lkstrp merged 3 commits intoPyPSA:mainfrom yechenyan:fix/retrieve_egon_data_error
lkstrp merged 3 commits intoPyPSA:mainfrom
yechenyan:fix/retrieve_egon_data_error
Conversation
…and ensure output directory exists
lkstrp
approved these changes
Feb 25, 2025
Member
lkstrp
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @yechenyan!
In general, wget is preferred over curl for downloading large files. On MacOS you can also just do brew install wget. But since these are not large files, it's fine. I am also not even sure why this was implemented via bash in the first place.
cpschau
pushed a commit
that referenced
this pull request
Mar 20, 2025
adapt co2 targets to scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and ensure output directory exists
Issue
I did not modify the configuration and ran the simulation using

snakemake -call all --configfile=config/config.public.yaml. The following error was encountered:The cause is as follows:
data/egonfolder, which will cause awget -oerror.wget.Solution
data/egonbefore downloading files.curlto download files.Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title