Skip to content

Prefect - #188

Draft
MarkTNO wants to merge 13 commits into
mainfrom
prefect
Draft

Prefect#188
MarkTNO wants to merge 13 commits into
mainfrom
prefect

Conversation

@MarkTNO

@MarkTNO MarkTNO commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@MarkTNO
MarkTNO marked this pull request as draft July 28, 2026 19:03

@cwang39403 cwang39403 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

Comment thread track_memory.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace container id with service name?

Maybe we can limit logs to no more than a certain number of lines (e.g. 5000)?
tail -n 5000 container_mem.log > container_mem.tmp && mv container_mem.tmp container_mem.log

Move this file into ./scripts?

Comment thread docker-compose.yml
- influxdb_data:/var/lib/influxdb

orchestrator_postgres_db: &orchestrator_postgres_db
omotes_postgres: &omotes_postgres

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&omotes_postgres needed?

Comment thread README.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and elegant, like it!

Aware that it is still WIP. Just writing it down so we don't forget these sections

  • Workflow configuration and updates
  • Gurobi license management
  • Postgres data backup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile

start, start-dev, and stop scripts have been simplified a lot which is great, but they are not being used at the moment. I think we can keep and mention these scripts here as they may be handy for some users.

Comment thread scripts/stop.sh
@@ -1,4 +1,4 @@
#!/bin/bash
. scripts/_select_docker_compose.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been removed in this PR.

Comment thread scripts/start.sh
@@ -2,5 +2,5 @@

. scripts/_select_docker_compose.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been removed in this PR.

{
"parameter_type": "duration",
"key_name": "timestep",
"prefect_flow_name": "omotes-optimizer",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omotes-simulator?

{
"parameter_type": "duration",
"key_name": "timestep",
"prefect_flow_name": "omotes-optimizer",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omotes-simulator

Comment thread docker-compose.yml
MINIO_ROOT_USER: ${MINIO_ACCESS_KEY}
MINIO_ROOT_PASSWORD: ${MINIO_SECRET}
MINIO_BUCKETS: prefect-cache,prefect-artifacts
entrypoint: >

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init-buckets.sh is defined but not being used.

Comment thread docker-compose.yml
condition: service_healthy
deploy_optimizer:
image: ghcr.io/project-omotes/omotes-optimizer:${OPTIMIZER_WORKER_VERSION}
profiles:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this approach!

Comment thread docker-compose.yml
deploy:
<<: *grow_worker_deploy
replicas: 1 # only 1 WLS available with a baseline of 1 active session
orchestrator:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE TO HAVE: rename to omotes_orchestrator as mentioned in the email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants