Update Dockerfile to using cache layer by piggy2303 · Pull Request #534 · Project-HAMi/HAMi

piggy2303 · 2024-10-08T04:05:16Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
optimize dockerfile so it can take advantage of cache layer to build docker image faster

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Signed-off-by: coderth <coderth@outlook.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

add use can specify use or not use device id feature

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

upgrade HAMi-core version

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

Signed-off-by: calvin <wen.chen@daocloud.io>

Delete useless symbols and fix descriptive errors in yaml examples.

feat: add github issue and pr templete

add a robot to mark labels

Optimize scheduling cache. Accelerate the discovery and deletion of nodes

…me-uniformly Use NODE_NAME as an environment variable uniformly

…odules/golang.org/x/net-0.22.0 Bump golang.org/x/net from 0.17.0 to 0.22.0

…odules/github.com/fsnotify/fsnotify-1.7.0 Bump github.com/fsnotify/fsnotify from 1.6.0 to 1.7.0

…ub_actions/actions/checkout-4 Bump actions/checkout from 2 to 4

Bumps [gotest.tools/v3](https://github.com/gotestyourself/gotest.tools) from 3.4.0 to 3.5.1. - [Release notes](https://github.com/gotestyourself/gotest.tools/releases) - [Commits](gotestyourself/gotest.tools@v3.4.0...v3.5.1) --- updated-dependencies: - dependency-name: gotest.tools/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ub_actions/docker/setup-buildx-action-3 Bump docker/setup-buildx-action from 1 to 3

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…ub_actions/docker/login-action-3.1.0 Bump docker/login-action from 1.10.0 to 3.1.0

…odules/gotest.tools/v3-3.5.1 Bump gotest.tools/v3 from 3.4.0 to 3.5.1

…odules/github.com/golang/glog-1.2.0 Bump github.com/golang/glog from 1.1.0 to 1.2.0

…ub_actions/arduino/setup-protoc-3.0.0 Bump arduino/setup-protoc from 1.1.2 to 3.0.0

…ub_actions/actions/setup-go-5 Bump actions/setup-go from 4 to 5

thedarkjimmy · 2024-10-11T07:08:46Z

good job

* Refactor helm admission webhook config Refactor .Values.scheduler.customWebhook block, adding support for defining webhook's reinvocationPolicy and resolving misleading structure. Resolves: Project-HAMi#531 Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com> * Restructure 'values.yaml' Rename 'webhook' block to 'admissionWebhook', get rid of 'mutatingWebhookConfiguration' block merging it's parameters with 'admissionWebhook' group. Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com> --------- Signed-off-by: Tigran Grigoryan <grigoryan.tigran119@gmail.com>

Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.24.0 to 0.27.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.24.0...0.27.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.0 to 4.4.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.4.0...v4.4.3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

wawa0210 · 2024-10-12T01:37:22Z

@piggy2303 Thanks your contribution, before approve,you need to fix the DCO issue

codecov · 2024-10-12T01:40:52Z

Codecov Report

❌ Patch coverage is 14.47903% with 632 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/device/ascend/device.go	2.75%	141 Missing ⚠️
pkg/device/cambricon/device.go	9.55%	121 Missing and 2 partials ⚠️
pkg/monitor/nvidia/cudevshr.go	0.00%	116 Missing ⚠️
pkg/monitor/nvidia/v0/spec.go	0.00%	55 Missing ⚠️
pkg/monitor/nvidia/v1/spec.go	0.00%	55 Missing ⚠️
pkg/device/hygon/device.go	14.28%	34 Missing and 2 partials ⚠️
pkg/device/nvidia/device.go	56.52%	28 Missing and 2 partials ⚠️
pkg/device/iluvatar/device.go	12.50%	28 Missing ⚠️
pkg/device/devices.go	12.50%	13 Missing and 1 partial ⚠️
pkg/scheduler/event.go	47.82%	10 Missing and 2 partials ⚠️
... and 3 more

Flag	Coverage Δ
unittests	`27.61% <14.47%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/k8sutil/pod.go	`73.33% <ø> (ø)`
pkg/oci/runtime_exec.go	`100.00% <ø> (ø)`
pkg/oci/runtime_mock.go	`100.00% <ø> (ø)`
pkg/oci/spec.go	`0.00% <ø> (ø)`
pkg/oci/spec_mock.go	`0.00% <ø> (ø)`
pkg/scheduler/pods.go	`87.80% <100.00%> (ø)`
pkg/scheduler/policy/constant.go	`100.00% <ø> (ø)`
pkg/scheduler/policy/gpu_policy.go	`81.48% <ø> (ø)`
pkg/scheduler/policy/node_policy.go	`100.00% <ø> (ø)`
pkg/scheduler/routes/route.go	`0.00% <ø> (ø)`
... and 20 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.8.0...v6.9.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.3...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

…rfile_optimize

…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>

Bumps ubuntu from 20.04 to 24.04. --- updated-dependencies: - dependency-name: ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

wawa0210 · 2024-10-14T00:12:53Z

@piggy2303 Can you rebase your commits ？

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.3...v4.4.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>

… into dockerfile_optimize

wawa0210 · 2024-10-15T06:48:47Z

@piggy2303 Hey, you need to rebase this pr to single commits

archlitchi · 2025-01-24T07:06:37Z

hello, could you resolve this conflict? so i can integrate?

CoderTH and others added 30 commits March 27, 2024 10:17

add lint script & fix code that fails static checking

fd23347

Signed-off-by: coderth <coderth@outlook.com>

Merge pull request Project-HAMi#225 from CoderTH/add-ci-lint

a375ed0

Merge pull request Project-HAMi#211 from lengrongfu/feat/add-user-uuid

1f8df63

add use can specify use or not use device id feature

modify ci

e529f78

fix code lint

dc54dc9

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

Merge pull request Project-HAMi#229 from lengrongfu/fix/lint-check

f9a6e98

upgrade HAMi-core version

0df52c8

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

Merge pull request Project-HAMi#230 from chaunceyjiang/core

04a570b

upgrade HAMi-core version

Use NODE_NAME as an environment variable uniformly

e7368cb

Signed-off-by: rongfu.leng <lenronfu@gmail.com>

add a robot to mark labels

11f07cc

Signed-off-by: calvin <wen.chen@daocloud.io>

Delete useless symbols and fix descriptive errors in yaml examples.

7156c22

Merge pull request Project-HAMi#233 from yangcheng-dev/master

d25935d

Delete useless symbols and fix descriptive errors in yaml examples.

Merge pull request Project-HAMi#159 from CoderTH/add-issue-temple

cc04c5b

feat: add github issue and pr templete

Merge pull request Project-HAMi#232 from calvin0327/add-label-robot

c038d9c

add a robot to mark labels

update

e2ae421

Merge pull request Project-HAMi#216 from chaunceyjiang/schedule_score

57d0892

Optimize scheduling cache. Accelerate the discovery and deletion of nodes

Merge pull request Project-HAMi#231 from lengrongfu/feat/NODE_NAME-na…

8fca4c5

…me-uniformly Use NODE_NAME as an environment variable uniformly

Merge pull request Project-HAMi#205 from Project-HAMi/dependabot/go_m…

5bb21c6

…odules/golang.org/x/net-0.22.0 Bump golang.org/x/net from 0.17.0 to 0.22.0

Merge pull request Project-HAMi#191 from Project-HAMi/dependabot/go_m…

94b3786

…odules/github.com/fsnotify/fsnotify-1.7.0 Bump github.com/fsnotify/fsnotify from 1.6.0 to 1.7.0

Merge pull request Project-HAMi#187 from Project-HAMi/dependabot/gith…

e665c54

…ub_actions/actions/checkout-4 Bump actions/checkout from 2 to 4

Merge pull request Project-HAMi#184 from Project-HAMi/dependabot/gith…

52d5e5d

…ub_actions/docker/setup-buildx-action-3 Bump docker/setup-buildx-action from 1 to 3

Merge pull request Project-HAMi#199 from Project-HAMi/dependabot/gith…

c978bb2

…ub_actions/docker/login-action-3.1.0 Bump docker/login-action from 1.10.0 to 3.1.0

Merge pull request Project-HAMi#189 from Project-HAMi/dependabot/go_m…

cb37e30

…odules/gotest.tools/v3-3.5.1 Bump gotest.tools/v3 from 3.4.0 to 3.5.1

Merge pull request Project-HAMi#190 from Project-HAMi/dependabot/go_m…

d7de632

…odules/github.com/golang/glog-1.2.0 Bump github.com/golang/glog from 1.1.0 to 1.2.0

Merge pull request Project-HAMi#186 from Project-HAMi/dependabot/gith…

f4fb5cb

…ub_actions/arduino/setup-protoc-3.0.0 Bump arduino/setup-protoc from 1.1.2 to 3.0.0

Merge pull request Project-HAMi#224 from Project-HAMi/dependabot/gith…

efb342f

…ub_actions/actions/setup-go-5 Bump actions/setup-go from 4 to 5

piggy2303 marked this pull request as draft October 8, 2024 04:06

piggy2303 marked this pull request as ready for review October 8, 2024 04:07

4gt-104 and others added 3 commits October 11, 2024 18:06

dependabot bot and others added 4 commits October 12, 2024 11:04

Update Dockerfile to using cache layer

db78048

Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

piggy2303 force-pushed the dockerfile_optimize branch 3 times, most recently from 9564ffd to db78048 Compare October 12, 2024 05:03

Merge branch 'master' of https://github.com/piggy2303/HAMi into docke…

8fa0823

…rfile_optimize

piggy2303 force-pushed the dockerfile_optimize branch 3 times, most recently from d01def6 to 8fa0823 Compare October 12, 2024 08:38

piggy2303 and others added 2 commits October 12, 2024 15:39

Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@u…

dd3b2c2

…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>

Bump ubuntu from 20.04 to 24.04 in /docker

36ef4c4

Bumps ubuntu from 20.04 to 24.04. --- updated-dependencies: - dependency-name: ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

dependabot bot and others added 4 commits October 14, 2024 10:28

Update Dockerfile to using cache layer

ade88a6

Signed-off-by: jimmy <myemail@example.com> Signed-off-by: piggy2303 <nguyentuananh23031997@gmail.com>

Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@u…

44396b7

…sers.noreply.github.com> Update Dockerfile Signed-off-by: TuanAnh Nguyen <33578509+piggy2303@users.noreply.github.com>

Merge branch 'dockerfile_optimize' of https://github.com/piggy2303/HAMi…

4ab22ed

… into dockerfile_optimize

wawa0210 approved these changes Dec 19, 2024

View reviewed changes

archlitchi force-pushed the master branch from ef0d42b to c79824a Compare January 20, 2026 04:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Dockerfile to using cache layer#534

Update Dockerfile to using cache layer#534
piggy2303 wants to merge 673 commits intoProject-HAMi:masterfrom
piggy2303:dockerfile_optimize

piggy2303 commented Oct 8, 2024

Uh oh!

thedarkjimmy commented Oct 11, 2024

Uh oh!

wawa0210 commented Oct 12, 2024

Uh oh!

codecov bot commented Oct 12, 2024 •

edited

Loading

Uh oh!

wawa0210 commented Oct 14, 2024

Uh oh!

wawa0210 commented Oct 15, 2024

Uh oh!

archlitchi commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

piggy2303 commented Oct 8, 2024

Uh oh!

thedarkjimmy commented Oct 11, 2024

Uh oh!

wawa0210 commented Oct 12, 2024

Uh oh!

codecov bot commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wawa0210 commented Oct 14, 2024

Uh oh!

wawa0210 commented Oct 15, 2024

Uh oh!

archlitchi commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

codecov bot commented Oct 12, 2024 •

edited

Loading