i18n: externalize hardcoded UI strings + complete French translation#392
Open
foXaCe wants to merge 1 commit into
Open
i18n: externalize hardcoded UI strings + complete French translation#392foXaCe wants to merge 1 commit into
foXaCe wants to merge 1 commit into
Conversation
Externalize hardcoded UI strings to res/values/strings.xml (247 -> 1038 keys) and add the complete French translation in res/values-fr/strings.xml (61 -> 1038, full parity), entirely in vouvoiement. - Compose Text/contentDescription/labels, dialogs, toasts, notifications -> stringResource(R.string.x) - ViewModels, repositories, updater, live TV and data layer -> getString; @ApplicationContext injected where missing - AuthEmailValidator.validate now returns @stringres resolved at call sites - Display-only localization for stored/compared values (settings option values, collection/rail titles, avatar and live-TV categories): the persisted English value is kept for matching/dedup, only the shown label is translated (localizeSettingValue / localizedCollectionTitle / avatarCategoryLabel / liveCategoryLabel helpers) - Technical terms and brands kept (Trakt, IPTV, EPG, Xtream, addon, stream, hero, Groq, Gemini, TDLib...) - French typography: typographic apostrophes, non-breaking spaces before : ? !, ellipsis; placeholders preserved - Both flavors compile (compileSideloadDebugKotlin + compilePlayDebugKotlin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Externalizes hardcoded user-facing strings to
res/values/strings.xmland adds a complete, parity-checked French translation inres/values-fr/strings.xml.strings.xml: 247 → 1038 keysvalues-fr/strings.xml: 61 → 1038 keys (full parity, French in vouvoiement throughout)compileSideloadDebugKotlin+compilePlayDebugKotlin)What changed
Text/contentDescription/ labels, dialogs, toasts, notifications →stringResource(R.string.x)context.getString(...);@ApplicationContextinjected where it was missingAuthEmailValidator.validatenow returns@StringRes Int?resolved at the call sitesOff/Any/Medium, collection & rail titles, avatar and live-TV categories): the stored English value is kept for matching/dedup/cloud-sync, and only the displayed label is translated via small@Composablehelpers (localizeSettingValue,localizedCollectionTitle,avatarCategoryLabel,liveCategoryLabel). This avoids freezing the locale or breaking comparisons.Conventions
'), non-breaking spaces before: ? !, ellipsis…%1$s/%1$dplaceholders preserved; EN ↔ FR parity verified (0 missing / 0 orphan / 0 duplicate)Not included (out of scope)
TMDB_LANGUAGESlanguage names in the language picker (≈53 entries — UX decision on native vs. translated names)AiKeyWebPageHTML page (separate sub-system)Context(stream quality/source names) that would need display-layer localization at the stream tiles