Skip to content

Remove 51 invalid County enum entries#7145

Merged
baogorek merged 1 commit intomainfrom
fix-invalid-county-entries
Jan 12, 2026
Merged

Remove 51 invalid County enum entries#7145
baogorek merged 1 commit intomainfrom
fix-invalid-county-entries

Conversation

@baogorek
Copy link
Copy Markdown
Collaborator

@baogorek baogorek commented Jan 9, 2026

Summary

Categories of Invalid Entries

  • 49 wrong state assignments (e.g., DORCHESTER_COUNTY_DE - Dorchester only exists in MD/SC)
  • 5 non-existent combinations (apostrophe handling issues like O'Brien → O_BRIEN_COUNTY_IA)
  • 11 encoding issues (PR municipios, special characters like Doña Ana)

Impact

  • Delaware now correctly has 3 counties (was 4 with fake DORCHESTER_COUNTY_DE)
  • All remaining county entries validated against Census 2020

Fixes #7144

Test plan

  • Verify Delaware has exactly 3 counties (Kent, New Castle, Sussex)
  • Verify no invalid county names remain in enum
  • Run existing county-related tests

🤖 Generated with Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3ddb69c) to head (1ceb893).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #7145      +/-   ##
===========================================
+ Coverage   97.00%   100.00%   +3.00%     
===========================================
  Files           7         1       -6     
  Lines         100      3175    +3075     
  Branches        1         0       -1     
===========================================
+ Hits           97      3175    +3078     
+ Misses          2         0       -2     
+ Partials        1         0       -1     
Flag Coverage Δ
unittests 100.00% <ø> (+3.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Validated against Census 2020 county reference data. These entries had wrong
state assignments (e.g., DORCHESTER_COUNTY_DE - Dorchester is in MD/SC not DE)
or non-existent county/state combinations.

Preserves 14 valid entries with special characters (PR municipios with accents,
MD counties with apostrophes, Doña Ana County NM) that were incorrectly flagged
due to encoding differences in the initial audit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@baogorek baogorek force-pushed the fix-invalid-county-entries branch from 7c862f0 to 1ceb893 Compare January 9, 2026 19:30
@baogorek baogorek changed the title Remove 65 invalid County enum entries Remove 51 invalid County enum entries Jan 9, 2026
@baogorek baogorek merged commit 9020d69 into main Jan 12, 2026
9 checks passed
@baogorek baogorek deleted the fix-invalid-county-entries branch January 12, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

County enum contains 65 invalid entries (wrong state assignments, non-existent counties)

2 participants