upstream: ros2_control deprecation replace fake with mock#32
Conversation
There was a problem hiding this comment.
I think all the URI switches from file:// to package:// are because my original branch was based on a separate moveit_studio branch we have set up.
If you wanna grab these changes, try rebasing on main and dropping the first 2 commits. Sorry.
I also am not sure if this should go into Humble because the parameter changes will break end users' workflows, all for a deprecation warning. If we are cutting a rolling release, I'd be OK with it there though.
|
@moriarty branch is rebased on main and contains just the changes we care about. Again, if we can possibly cut a |
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 352 352
=====================================
Misses 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@sea-bass yeh that makes sense, I'll first do a 0.0.1 release without this change and then merge this after and create a humble branch. |
This fixes the depreciation warning introduced upstream:
ros-controls/ros2_control@9d5d524