Skip to content

Doesn't work with plugin Hirak/prestissimo#20

Open
mickaelperrin wants to merge 2 commits into
PhilippBaschke:masterfrom
mickaelperrin:patch-1
Open

Doesn't work with plugin Hirak/prestissimo#20
mickaelperrin wants to merge 2 commits into
PhilippBaschke:masterfrom
mickaelperrin:patch-1

Conversation

@mickaelperrin

Copy link
Copy Markdown

When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs after hirak/prestissimo.
As both are running with a priority set to 0, setting this one to -1 resolves the issue.

When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs *after* hirak/prestissimo.
As both are running with a priority set to 0, setting this one to -1 resolves the issue.
@partounian

Copy link
Copy Markdown

Can we please get this integrated?

@PhilippBaschke

Copy link
Copy Markdown
Owner

Thank you @mickaelperrin for your research and for submitting a pull request to solve the issue! ☺️
Sorry for the late answer, I was pretty busy lately 😞
Would you be so kind to adapt the failing test to reflect the new requirements? Let me know if you need help with that (the PHPUnit Manual can be handy resource).

Thank you again ☺️

@tucq88

tucq88 commented Sep 13, 2017

Copy link
Copy Markdown

Can't wait until this being merged T_T

@partounian

Copy link
Copy Markdown

I suggest someone forks this project and updates it

@tucq88

tucq88 commented Oct 14, 2017

Copy link
Copy Markdown

Could you merge this @PhilippBaschke ?

@cooperaj

cooperaj commented Feb 9, 2018

Copy link
Copy Markdown

Just had to remove prestissimo for this one.

@strarsis

strarsis commented Apr 14, 2018

Copy link
Copy Markdown

@PhilippBaschke: +1
Also had an issue with hirak/prestissimo. After uninstalling it works.

@strarsis

Copy link
Copy Markdown

@PhilippBaschke: Are there plans for merging this in the near future? Just had this issue again.

@davidwebca

Copy link
Copy Markdown

Same. Get it every two weeks everytime I start a new project... 😭

@strarsis

strarsis commented Jul 12, 2018

Copy link
Copy Markdown

@randmanrjr: Have you (still) write access to this repository? Could you merge this in
(and publish a new release to packagist)?

@randmanrjr

Copy link
Copy Markdown
Contributor

@strarsis I don't have write access to this repository. In the past, I made a small contribution via a pull request.

@strarsis

strarsis commented Aug 9, 2018

Copy link
Copy Markdown

Strange, I just tried it with hirak/prestissimo installed and it worked. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants