Minor code cleanup - fixed a bunch of wrong type annotations, and also replaced 'this' wit…#42
Merged
regdos merged 4 commits intoJun 22, 2026
Conversation
…h 'block' variable in phtml files.
Contributor
|
@hostep Please remove changes from files in lib/OpenPayU/* because there files are from external library (openpayu_sdk). |
|
@regdos why is that library included in the codebase instead of being installed with composer? |
Contributor
|
Historically, this was done so that the plugin could be used without installing it via Composer. We will consider removing and adding dependencies in the future. |
…ong-type-annoations-and-other-minor-things
Contributor
Author
|
@regdos: Done! |
Contributor
Author
|
I've also opened PayU-EMEA/openpayu_php#145 a few minutes ago in case you didn't see it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h 'block' variable in phtml files.
While working on #41 I noticed some minor warnings phpstan found about wrong type annotations in various files.
These got fixed here.
I also replaced the incorrect
$this->calls with$block->calls in phtml files. It does work with$thisbut that usage is discouraged in Magento.