Skip to content

added --browser option support for deploy script - #69

Merged
PaulRBerg merged 4 commits into
PaulRBerg:mainfrom
touchmeangel:browser
May 25, 2026
Merged

added --browser option support for deploy script#69
PaulRBerg merged 4 commits into
PaulRBerg:mainfrom
touchmeangel:browser

Conversation

@touchmeangel

Copy link
Copy Markdown
Contributor

Summary

This PR adds support for the --browser option to the deploy script in the Solidity template repository.

The goal is to provide an alternative deployment flow that can be useful for browser-based wallet interactions and environments where mnemonic-based deployment is not ideal.

Now you can just run forge script script/Deploy.s.sol --rpc-url sepolia --broadcast --browser and script will start a server listening at localhost:9545 (which you can expose if on ssh server)

Notes

I had some concerns about introducing this directly into main alongside the existing mnemonic phrase deployment script, since maintaining multiple deployment approaches in the template could gradually make the repository feel overloaded with optional tooling and configuration paths.

Because of that, I think this feature may be better treated as optional functionality rather than part of the default template experience.

One possible approach could be:

keeping this in a separate branch dedicated to browser-based deployment support, or
introducing it behind clearer optional setup paths/documentation so the default template remains minimal.

That said, I am still opening this PR against main because the feature itself may still provide value to users who prefer browser-based deployment workflows.

I’m also open to better proposals regarding how this should be structured or exposed within the repository.

@PaulRBerg PaulRBerg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR.

It's a good idea to use --browser. But I don't want this to become the sole deployment method. There should be two:

  1. Mnemonic-based (the default and what we have had thus far)
  2. Browser-based

So let's do this - Add a new DeployBrowser.s.sol script and keep Deploy.s.sol as is. We will also need to update the guidance provided in AGENTS.md.

You may need to rebase from main, @touchmeangel.

@touchmeangel

Copy link
Copy Markdown
Contributor Author

Hey, yes I agree maybe it was better all along to create a separate Deploy script. I will rebase it in next few hours

@touchmeangel touchmeangel reopened this May 23, 2026
@touchmeangel

touchmeangel commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

Thank you so much for reviewing this PR @PaulRBerg

@PaulRBerg PaulRBerg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @touchmeangel, merging now.

@PaulRBerg
PaulRBerg merged commit 3af27e8 into PaulRBerg:main May 25, 2026
3 checks passed
@touchmeangel

Copy link
Copy Markdown
Contributor Author

Thanks @touchmeangel, merging now.

Thank you actually!

@touchmeangel
touchmeangel deleted the browser branch May 25, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants