added --browser option support for deploy script - #69
Merged
Conversation
PaulRBerg
requested changes
May 23, 2026
Owner
There was a problem hiding this comment.
Hey, thanks for the PR.
It's a good idea to use --browser. But I don't want this to become the sole deployment method. There should be two:
- Mnemonic-based (the default and what we have had thus far)
- Browser-based
So let's do this - Add a new DeployBrowser.s.sol script and keep Deploy.s.sol as is. We will also need to update the guidance provided in AGENTS.md.
You may need to rebase from main, @touchmeangel.
Contributor
Author
|
Hey, yes I agree maybe it was better all along to create a separate Deploy script. I will rebase it in next few hours |
…stead of giving out MNEMONIC
Contributor
Author
|
Thank you so much for reviewing this PR @PaulRBerg |
PaulRBerg
approved these changes
May 25, 2026
PaulRBerg
left a comment
Owner
There was a problem hiding this comment.
Thanks @touchmeangel, merging now.
Contributor
Author
Thank you actually! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
--browseroption to the deploy script in the Solidity template repository.The goal is to provide an alternative deployment flow that can be useful for browser-based wallet interactions and environments where mnemonic-based deployment is not ideal.
Now you can just run
forge script script/Deploy.s.sol --rpc-url sepolia --broadcast --browserand script will start a server listening at localhost:9545 (which you can expose if on ssh server)Notes
I had some concerns about introducing this directly into main alongside the existing mnemonic phrase deployment script, since maintaining multiple deployment approaches in the template could gradually make the repository feel overloaded with optional tooling and configuration paths.
Because of that, I think this feature may be better treated as optional functionality rather than part of the default template experience.
One possible approach could be:
keeping this in a separate branch dedicated to browser-based deployment support, or
introducing it behind clearer optional setup paths/documentation so the default template remains minimal.
That said, I am still opening this PR against main because the feature itself may still provide value to users who prefer browser-based deployment workflows.
I’m also open to better proposals regarding how this should be structured or exposed within the repository.