Skip to content

Fix skipping tests when dependabot runs#149

Merged
palisadoes merged 2 commits intoPalisadoesFoundation:mainfrom
palisadoes:docusaurus-dependabot-1775696898
Apr 9, 2026
Merged

Fix skipping tests when dependabot runs#149
palisadoes merged 2 commits intoPalisadoesFoundation:mainfrom
palisadoes:docusaurus-dependabot-1775696898

Conversation

@palisadoes
Copy link
Copy Markdown
Contributor

@palisadoes palisadoes commented Apr 9, 2026

Docusaurus dependabot 1775696898

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow with an additional gating step before deployment tests.
    • Updated code formatting configuration to ignore additional lock files.
    • Removed unused package dependency.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Our Pull Request Approval Process

This PR will be reviewed according to our:

  1. Palisadoes Contributing Guidelines

  2. AI Usage Policy

Your PR may be automatically closed if:

  1. Our PR template isn't filled in correctly
  2. You haven't correctly linked your PR to an issue

👉 https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Thanks for contributing!

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 70c61452-6af2-4dcd-a6c9-1f6127c32042

📥 Commits

Reviewing files that changed from the base of the PR and between 9693eb8 and 8bfe03d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .github/workflows/pull-request.yml
  • .prettierignore
  • package.json
💤 Files with no reviewable changes (1)
  • package.json

Walkthrough

Updated GitHub Actions workflow to introduce a new gating job (Pre-Test-Checks-Pass) that ensures code quality checks pass before deployment tests execute. Removed the docusaurus dependency from package.json and updated .prettierignore to exclude pnpm-lock.yaml files.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/pull-request.yml
Added new job Pre-Test-Checks-Pass that runs unconditionally after Code-Quality-Checks (unless cancelled or failed). Updated Test-Docusaurus-Deployment to depend on the new job instead of directly on code quality checks, establishing an explicit gating step. Minor whitespace adjustments.
Build Configuration
.prettierignore, package.json
Added pnpm-lock.yaml to prettier ignore rules with trailing newline. Removed docusaurus dependency version ^1.14.7 from package dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description 'Docusaurus dependabot 1775696898' is extremely vague and does not follow the required template structure, missing all key sections like motivation, issue number, testing information, and summary. Expand the description to follow the template: explain what problem this fixes, reference the related issue, clarify what was changed and why, document any tests added, and confirm reading the contributing guide.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix skipping tests when dependabot runs' clearly describes the main change—addressing test skipping behavior during dependabot runs, which aligns with the workflow modification and dependency removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@palisadoes palisadoes merged commit 30dea1f into PalisadoesFoundation:main Apr 9, 2026
9 checks passed
@palisadoes palisadoes deleted the docusaurus-dependabot-1775696898 branch April 9, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant