add async post_observation() to AsyncERClient by JoshuaVulcan · Pull Request #24 · PADAS/er-client

JoshuaVulcan · 2026-02-10T23:37:58Z

Summary

Adds post_observation() to AsyncERClient, matching the sync ERClient's existing method
Supports posting a single observation or a list of observations
Applies _clean_observation() to normalize recorded_at datetime objects to ISO format strings
7 new tests covering success (single + list), datetime cleaning, timeouts, 403, 404, and 409 responses

Test plan

uv run pytest -- all 97 tests pass (90 existing + 7 new)

Adds post_observation() to the async client, matching the sync ERClient's existing method. Supports single observations and lists, applies _clean_observation() to normalize recorded_at to ISO format. ERA-12672 Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

This PR adds the post_observation() async method to AsyncERClient, bringing it to feature parity with the existing sync ERClient. The implementation correctly mirrors the sync version by handling both single observations and lists, applying datetime normalization through _clean_observation(), and posting to the observations endpoint.

Changes:

Added async def post_observation() method to AsyncERClient class
Added comprehensive test suite with 7 tests covering success cases, datetime cleaning, and various error scenarios (timeout, 403, 404, 409)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
erclient/client.py	Added async post_observation() method that mirrors the sync version, handling single/list observations with datetime cleaning
tests/async_client/test_post_observation.py	New test file with 7 tests covering success, list handling, datetime conversion, and error scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Exercises the isinstance(observation, (list, set)) branch with a monkeypatched _clean_observation since dicts are unhashable and cannot be placed in a real set. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

…ervation tests Co-authored-by: Cursor <cursoragent@cursor.com>

Register observation route with full URL (service_root + '/observations') so respx matches the client request. urljoin(base_url, 'observations') yields .../api/observations, which did not match .../api/v1.0/observations. Co-authored-by: Cursor <cursoragent@cursor.com>

Omit base_url from respx.mock() and register the observations route with the full URL only. Avoids base_url merging that can prevent the route from matching the actual request in CI. Co-authored-by: Cursor <cursoragent@cursor.com>

… async tests Match test_post_sensor_observation pattern so respx route matches the request URL across Python 3.10-3.12. Remove unused re import. Co-authored-by: Cursor <cursoragent@cursor.com>

…ng slash) Co-authored-by: Cursor <cursoragent@cursor.com>

Match PR #24 pattern so mocks match client request URL after #23. Add docs/AGENT_LEARNINGS.md for merge and test patterns. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

+import respx
+
+from erclient import (ERClientException, ERClientNotFound,
+                      ERClientPermissionDenied, ERClientServiceUnreachable)


+        response = await er_client.post_observation(observations)
+        assert route.called


+        with pytest.MonkeyPatch.context() as mp:
+            mp.setattr(er_client, '_clean_observation', lambda o: list(o))
+            response = await er_client.post_observation(observations)
+


+    This test uses a frozenset wrapper to exercise the isinstance(obs, (list, set))
+    branch and confirm it produces a list payload.


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

+import respx
+
+from erclient import (ERClientException, ERClientNotFound,
+                      ERClientPermissionDenied, ERClientServiceUnreachable)


+    """Verify that a set input is iterated and each element cleaned individually.
+
+    Note: in practice, observation dicts are unhashable so callers use lists.
+    This test uses a frozenset wrapper to exercise the isinstance(obs, (list, set))
+    branch and confirm it produces a list payload.
+    """
+    # Use simple hashable stand-ins to verify the set branch
+    obs_a = ("obs_a",)
+    obs_b = ("obs_b",)
+    observations = {obs_a, obs_b}  # a real set


+        with pytest.MonkeyPatch.context() as mp:
+            mp.setattr(er_client, '_clean_observation', lambda o: list(o))
+            response = await er_client.post_observation(observations)
+
+        assert route.called
+        request_body = json.loads(route.calls[0].request.content)
+        assert isinstance(request_body, list)
+        assert len(request_body) == 2
+        await er_client.close()


+async def test_post_observation_conflict(er_client, position, conflict_response):
+    async with respx.mock(
+            base_url=er_client._api_root("v1.0"), assert_all_called=False
+    ) as respx_mock:
+        route = respx_mock.post('observations')
+        route.return_value = httpx.Response(
+            httpx.codes.CONFLICT, json=conflict_response)
+        with pytest.raises(ERClientException) as exc_info:
+            await er_client.post_observation(position)
+        assert exc_info.value.status_code == httpx.codes.CONFLICT
+        assert route.called


- Drop unused import ERClientServiceUnreachable; import ERClientRateLimitExceeded instead (Copilot: unused import / autoflake). - Assert response == {} in list-success test instead of leaving the return value unused (Copilot: unused variable + missing assertion). - Remove unused response assignment in set-input test (Copilot: unused variable). - Fix set-input test docstring that said "frozenset wrapper" while the code uses a plain set (Copilot: docstring mismatch). - Tighten the 409 test to assert ERClientRateLimitExceeded, the specific subclass _handle_http_status_error maps CONFLICT to, instead of the generic ERClientException (Copilot: assert specific exception type). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

JoshuaVulcan requested a review from Copilot February 10, 2026 23:38

Copilot started reviewing on behalf of JoshuaVulcan February 10, 2026 23:38 View session

JoshuaVulcan requested review from chrisdoehring and chrisj-er February 10, 2026 23:40

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Comment thread tests/async_client/test_post_observation.py Outdated

Comment thread tests/async_client/test_post_observation.py

Comment thread tests/async_client/test_post_observation.py Outdated

Comment thread tests/async_client/test_post_observation.py

JoshuaVulcan added autoreviewing PR is currently being auto-reviewed and removed autoreviewing PR is currently being auto-reviewed labels Feb 11, 2026

JoshuaVulcan and others added 2 commits February 11, 2026 08:53

add test for set input type in async post_observation

b6b733e

Exercises the isinstance(observation, (list, set)) branch with a monkeypatched _clean_observation since dicts are unhashable and cannot be placed in a real set. Co-authored-by: Cursor <cursoragent@cursor.com>

Update tests/async_client/test_post_observation.py

1c3fc37

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

JoshuaVulcan requested a review from a team as a code owner February 11, 2026 22:26

JoshuaVulcan and others added 8 commits February 11, 2026 14:32

Fix respx mock path: use 'observations' not '/observations'

4d09c9e

Co-authored-by: Cursor <cursoragent@cursor.com>

Fix respx mock: use 'observations' (no leading slash) in all post_obs…

a4f9170

…ervation tests Co-authored-by: Cursor <cursoragent@cursor.com>

Fix observations mock: use base_url + path '/observations' like other…

7d0a1fb

… async tests Match test_post_sensor_observation pattern so respx route matches the request URL across Python 3.10-3.12. Remove unused re import. Co-authored-by: Cursor <cursoragent@cursor.com>

Match test_post_report convention: mock path 'observations' (no leadi…

68b4971

…ng slash) Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into ERA-12672/async-post-observation

8c5cdaf

fix:duh. api root misinstrumentation.

6d4096c

Merge main into ERA-12672/async-post-observation

9a32a8c

chrisdoehring previously approved these changes Mar 13, 2026

View reviewed changes

chrisdoehring closed this May 22, 2026

chrisdoehring reopened this May 22, 2026

chrisdoehring requested a review from Copilot May 22, 2026 21:53

Copilot started reviewing on behalf of chrisdoehring May 22, 2026 21:53 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

chrisdoehring requested a review from Copilot May 26, 2026 20:26

Copilot started reviewing on behalf of chrisdoehring May 26, 2026 20:26 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

chrisdoehring dismissed their stale review via ea44eb7 May 26, 2026 20:44

chrisdoehring requested a review from Copilot May 26, 2026 20:46

Copilot started reviewing on behalf of chrisdoehring May 26, 2026 20:47 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

chrisdoehring approved these changes May 26, 2026

View reviewed changes

chrisdoehring merged commit f04c66a into main May 26, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add async post_observation() to AsyncERClient#24

add async post_observation() to AsyncERClient#24
chrisdoehring merged 13 commits into
mainfrom
ERA-12672/async-post-observation

JoshuaVulcan commented Feb 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		response = await er_client.post_observation(observations)
		assert route.called

		This test uses a frozenset wrapper to exercise the isinstance(obs, (list, set))
		branch and confirm it produces a list payload.

Conversation

JoshuaVulcan commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JoshuaVulcan commented Feb 10, 2026 •

edited

Loading